Page MenuHomePhorge

reformat error messages

Authored by dhoffend on Apr 2 2020, 2:15 AM.
Referenced Files
Unknown Object (File)
Tue, Jun 11, 7:13 AM
Unknown Object (File)
Sun, Jun 9, 5:20 AM
Unknown Object (File)
Sun, Jun 9, 2:56 AM
Unknown Object (File)
Fri, Jun 7, 12:27 PM
Unknown Object (File)
Thu, Jun 6, 9:40 PM
Unknown Object (File)
Thu, Jun 6, 3:31 PM
Unknown Object (File)
Thu, Jun 6, 4:39 AM
Unknown Object (File)
Thu, Jun 6, 1:05 AM



Send correct error messages depending on the type of autodiscover method. Microsoft == XML Error Message, JSON == json formatted error message. Sending a generic error 500 is harder to debug in the end.

Diff Detail

rAC autoconf
Lint Not Applicable
Tests Not Applicable

Event Timeline

dhoffend created this revision.
machniak requested changes to this revision.Apr 5 2020, 8:26 AM
machniak subscribed.
machniak added inline comments.

I guess it should be ErrorCode.

This revision now requires changes to proceed.Apr 5 2020, 8:26 AM
  • switch to an error code a real ms server sends out on invalid request

You're right. I've fixed the typo and replaced the msxml errorcode with one that a real exchange server sends outs. Just in case something weird could happing.

  • one more typo in json protocol
  • change error-id to the an integer
  • always send unsigned int32
This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2023, 12:03 PM
Closed by commit rACc526e21729a7: reformat error messages (authored by dhoffend, committed by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.