Page MenuHomePhorge

reformat error messages
ClosedPublic

Authored by dhoffend on Apr 2 2020, 2:15 AM.
Tags
None
Referenced Files
F12326649: D1108.id2935.diff
Fri, May 24, 11:22 AM
F12326451: D1108.id2947.diff
Fri, May 24, 11:06 AM
F12326409: D1108.id2902.diff
Fri, May 24, 11:03 AM
F12322020: D1108.id2941.diff
Fri, May 24, 6:36 AM
F12321180: D1108.id.diff
Fri, May 24, 5:18 AM
F12319563: D1108.id2935.diff
Fri, May 24, 12:59 AM
F12317529: D1108.id2953.diff
Thu, May 23, 7:03 PM
F12316452: D1108.diff
Thu, May 23, 6:43 PM
Subscribers

Details

Summary

Send correct error messages depending on the type of autodiscover method. Microsoft == XML Error Message, JSON == json formatted error message. Sending a generic error 500 is harder to debug in the end.

Diff Detail

Repository
rAC autoconf
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dhoffend created this revision.
machniak requested changes to this revision.Apr 5 2020, 8:26 AM
machniak subscribed.
machniak added inline comments.
lib/AutodiscoverJson.php
124

I guess it should be ErrorCode.

This revision now requires changes to proceed.Apr 5 2020, 8:26 AM
  • switch to an error code a real ms server sends out on invalid request

You're right. I've fixed the typo and replaced the msxml errorcode with one that a real exchange server sends outs. Just in case something weird could happing.

  • one more typo in json protocol
  • change error-id to the an integer
  • always send unsigned int32
This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2023, 12:03 PM
Closed by commit rACc526e21729a7: reformat error messages (authored by dhoffend, committed by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.