Page MenuHomekolab.org

reformat error messages
Needs ReviewPublic

Authored by dhoffend on Apr 2 2020, 2:15 AM.

Details

Reviewers
machniak
Group Reviewers
Autoconf Developers
Summary

Send correct error messages depending on the type of autodiscover method. Microsoft == XML Error Message, JSON == json formatted error message. Sending a generic error 500 is harder to debug in the end.

Diff Detail

Repository
rAC autoconf
Branch
error-codes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29017
Build 10519: arc lint + arc unit

Event Timeline

dhoffend requested review of this revision.Apr 2 2020, 2:15 AM
dhoffend created this revision.
dhoffend edited the summary of this revision. (Show Details)Apr 2 2020, 2:16 AM
dhoffend updated this revision to Diff 2902.Apr 2 2020, 2:18 AM
  • fix whitespace
machniak requested changes to this revision.Apr 5 2020, 8:26 AM
machniak added a subscriber: machniak.
machniak added inline comments.
lib/AutodiscoverJson.php
124

I guess it should be ErrorCode.

This revision now requires changes to proceed.Apr 5 2020, 8:26 AM
dhoffend updated this revision to Diff 2929.Apr 6 2020, 9:50 PM
  • fixed typo
dhoffend updated this revision to Diff 2935.Apr 6 2020, 9:57 PM
  • switch to an error code a real ms server sends out on invalid request
dhoffend planned changes to this revision.Apr 6 2020, 9:59 PM

You're right. I've fixed the typo and replaced the msxml errorcode with one that a real exchange server sends outs. Just in case something weird could happing.

dhoffend requested review of this revision.Apr 6 2020, 9:59 PM
dhoffend updated this revision to Diff 2941.Apr 6 2020, 10:58 PM
  • one more typo in json protocol
dhoffend updated this revision to Diff 2947.Apr 7 2020, 12:06 AM
  • change error-id to the an integer
dhoffend updated this revision to Diff 2953.Apr 7 2020, 1:59 AM
  • always send unsigned int32