- Implement proper users listing, added tests for it
- Deleting users/accounts
TODO: more browser tests
vanmeeuwen |
Restricted Project |
TODO: more browser tests
./phpunit
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/app/Observers/DomainObserver.php | ||
---|---|---|
54 | It could, indeed. Then we should change isDeleted() so it also returns true when !empty($this->deleted_at), or not? I don't want to make things more complicated at the moment. | |
57 | save() would work, but would generate updated/updating event which we don't need/want. |
src/app/Observers/DomainObserver.php | ||
---|---|---|
54 | The question is then how the complete process of deleting a domain (or a user for that matter) is reflected in real life, vs. the database record. I believe I intended for the database to reflect in 'deleted_at' the semantics for UI/UX -- including billing and pro rata temporis if you will, and for STATUS_DELETED to be the final confirmation. In a sense, deleting could spawn the dispatched process -- it creates a series of actions to need to have occurred much like creating a user does (ldap ready, imap ready). I think it is there where I figured STATUS_DELETED would add value compared to just deleted_at. | |
57 | I think we need to settle what deleting and deleted is compared to deleted_at vs. STATUS_DELETED, before we need to consider $domain->save() and its triggering of updating()/updated(). | |
src/app/Observers/UserObserver.php | ||
95 | Think... "remove entitlements billed to wallets owned". When john@kolab.org owns a wallet to which all entitlements associated with any @kolab.org-related entitlements are billed -- and how would he not?? --, then iterating over his wallets and entitlements billed to said wallets is a very predictable path. |
Will require rebasing on to current master.
src/resources/vue/components/User/Profile.vue | ||
---|---|---|
60 | This is where a merge on to current origin/master fails. Please double-check the intended result. |