HomePhorge

(#4487) When setting environment on a host, ensure it is a string.
f656818bcd7cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#4487) When setting environment on a host, ensure it is a string.

Before this change when environment strings were read out of the storeconfigs
database, they were eventually converted up to Puppet::Node::Environment
objects. When these objects are returned to the storeconfigs database,
ActiveRecord dumps them as YAML, which begins the death-spiral of YAML.

This change makes it so the host will always store the environment as a string,
preventing the Puppet::Node::Environment object from being YAMLized, and stored
as such in the database.

This change was based on one by Richard Crowley.

Paired-with: Jacob Helwig <jacob@puppetlabs.com>
Reviewed-by: Jesse Wolfe <jesse@puppetlabs.com>
Signed-off-by: Richard Crowley <r@rcrowley.org>

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU0b9c7adce13c: Merge branch 'maint/2.6.next/defined_type_has_two_parents' into 2.6.next
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPUf656818bcd7c: (#4487) When setting environment on a host, ensure it is a string. (authored by Josh Cooper <josh@puppetlabs.com>).Apr 26 2011, 11:02 PM