HomePhorge

(#16581) Refactor code for sid validation
f08fc399b5baUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#16581) Refactor code for sid validation

Previously, the windows file provider knew too much about how to validate
a sid, e.g. catching a specific windows-specific exception.

This commit moves that logic into a valid_sid? method and updates the
file provider to call it. In doing so, the logic for string_to_sid_ptr
is simplier, in that it always expects a block.

It also removes tests that were refactored into sid_spec.rb in an earlier
commit.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUc60a82dc483c: (#16581) Deprecate sid_for_account
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPUf08fc399b5ba: (#16581) Refactor code for sid validation (authored by Josh Cooper <josh@puppetlabs.com>).Oct 24 2012, 8:36 PM