HomePhorge

(#6749) disable Action#invoke for this release.
c52261c7aa86Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#6749) disable Action#invoke for this release.

So, we have Action#invoke, but it binds to the declaring class, not to the
correct instance. Solving all the subtle issues around threads, global state,
and bindings without causing us too much pain is actually pretty hard, so
instead we pull the feature.

It can be enabled again in a future release and, being a strict extension
feature, we can do that without overly hurting anyone. We still have full
access to the invocation through a marginally less pleasant syntax, but one
that people MUST be able to arrange to allow invoke to work, so on that front
we are clean.

Reviewed-By: Pieter van de Bruggen <pieter@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU1635454755fa: (#6749) Remove "save does not work" language from strings.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUc52261c7aa86: (#6749) disable Action#invoke for this release. (authored by Daniel Pittman <daniel@puppetlabs.com>).Apr 4 2011, 7:19 PM