HomePhorge

(#8356) Specify setting type for color
a4378128c214Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#8356) Specify setting type for color

Because we default the color setting to "false" on Microsoft Windows,
the heuristics used to detect which type of setting we're using were
getting confused, and mis-detected color as being a BooleanSetting
rather than just a Setting.

By specifying that color is a "Setting", we can skip the
auto-detection, and avoid this problem entirely.

Reviewed-by: Josh Cooper <josh@puppetlabs.com>
(cherry picked from commit b84bdbf31bbb0c5d5501bf6f32a9c0d0dc6acc94)

Details

Provenance
Jacob Helwig <jacob@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUaf2446ad8ebf: (#8268) Fix resource harness spec tests
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPUa4378128c214: (#8356) Specify setting type for color (authored by Jacob Helwig <jacob@puppetlabs.com>).Aug 19 2011, 10:48 PM