HomePhorge

(#8356) Specify setting type for color
b84bdbf31bbbUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#8356) Specify setting type for color

Because we default the color setting to "false" on Microsoft Windows,
the heuristics used to detect which type of setting we're using were
getting confused, and mis-detected color as being a BooleanSetting
rather than just a Setting.

By specifying that color is a "Setting", we can skip the
auto-detection, and avoid this problem entirely.

Reviewed-by: Josh Cooper <josh@puppetlabs.com>

Details

Provenance
Jacob Helwig <jacob@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU9774c363c9ce: Merge branch 'ticket/master/8356-default-color-should-be-false-on-windows'
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPUb84bdbf31bbb: (#8356) Specify setting type for color (authored by Jacob Helwig <jacob@puppetlabs.com>).Jul 12 2011, 11:57 PM