HomePhorge

Eliminate `symbolize` everywhere, and remove it.
a09df46f5818Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Eliminate symbolize everywhere, and remove it.

The whole symbolize API was confusing and complex: because it didn't do any
type enforcement, just passed through arbitrary data, we had very unclear API
in a whole pile of places.

This replaces that method entirely with a more rigid definition: we intern in
a bunch of places, add the occasional clear failure mode, and then delete the
original definition.

This eliminates one point of complexity from the codebase.

(These other uses have no notable performance penalty, just code complexity
and clarity issues.)

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU4029c597ccc3: Use `intern` rather than `symbolize` in Puppet::Type
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUa09df46f5818: Eliminate `symbolize` everywhere, and remove it. (authored by Daniel Pittman <daniel@puppetlabs.com>).Jul 14 2012, 12:30 AM