HomePhorge

[#4798] Puppet doc manifests documentation mode broken
99c1019e1d34Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

[#4798] Puppet doc manifests documentation mode broken

When running puppet doc, if the directory containing the user's
specified manifest file overlaps with the modules directory (i.e. they
are the same directory or one contains the other), Puppet doc would
try to parse the overlapping files twice, triggering an exception
which made the documentation run fail.

Fixed the bug by adding a check to the RDoc::Parser#scan method to
prevent re-parsing of files that have already been parsed. Also added
a spec test to verify that this works.

Details

Provenance
Paul Berry <paul@puppetlabs.com>Authored on
Markus Roberts <Markus@reality.com>Committed on Sep 23 2010, 6:11 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU8cd1540f82cb: [#4692] undefined variables cause :undef to be passed to functions
Branches
Unknown
Tags
Unknown

Event Timeline

Markus Roberts <Markus@reality.com> committed rPU99c1019e1d34: [#4798] Puppet doc manifests documentation mode broken (authored by Paul Berry <paul@puppetlabs.com>).Sep 23 2010, 6:11 AM