HomePhorge

Deprecate RestAuthConfig#allowed? in favor of #check_authorization
7e6fc0d80ccdUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Deprecate RestAuthConfig#allowed? in favor of #check_authorization

#allowed? was a poorly named method since it isn't actually a predicate
method. Instead of returning a boolean, this methods throws an
exception when the access is denied (in order to keep the full context
of what ACE triggered the deny).

Given that #allowed? was overriding the behavior from AuthConfig, we
leave a version of #allowed? in place that will issue a deprecation
warning before delegating to #check_authorization. Once support for
XML-RPC agents is removed from the master, we will be able to remove
this delegation, since there should no longer be a reason for a
distinction between AuthConfig and RestAuthConfig.

Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
Signed-off-by: Jacob Helwig <jacob@puppetlabs.com>

Details

Provenance
Brice Figureau <brice-puppet@daysofwonder.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Jul 26 2011, 11:04 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU6401dfe5602f: Fix #6026 - security file should support inline comments
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU7e6fc0d80ccd: Deprecate RestAuthConfig#allowed? in favor of #check_authorization (authored by Brice Figureau <brice-puppet@daysofwonder.com>).Jul 26 2011, 11:04 PM