HomePhorge

Remove Puppet::Util::Cacher usage from Puppet::Util::Settings
546e0f98e3c6Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Remove Puppet::Util::Cacher usage from Puppet::Util::Settings

The path attribute was being unnecessarily cached. The value is a LoadedFile
instance, which already knows how to check whether it needs to be reloaded. The
act of reparsing was being triggered separately from the cacher mechanism.

The comment indicated this value was only being cached so it could be easily
cleared for tests, but it wasn't being cleared for tests. Thus, there is no
reason for this attribute to be cached, so remove it.

Reviewed-By: Jacob Helwig <jacob@puppetlabs.com>
(cherry picked from commit bdcb9be3b5d7cd54548cbeb7b13bee6fe4e730f7)

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Aug 19 2011, 10:52 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUb6b54981bb09: Remove Util::Cacher usage from SSL::CertificateAuthority
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU546e0f98e3c6: Remove Puppet::Util::Cacher usage from Puppet::Util::Settings (authored by Nick Lewis <nick@puppetlabs.com>).Aug 19 2011, 10:52 PM