HomePhorge

Remove Puppet::Util::Cacher usage from Puppet::Util::Settings
bdcb9be3b5d7Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Remove Puppet::Util::Cacher usage from Puppet::Util::Settings

The path attribute was being unnecessarily cached. The value is a LoadedFile
instance, which already knows how to check whether it needs to be reloaded. The
act of reparsing was being triggered separately from the cacher mechanism.

The comment indicated this value was only being cached so it could be easily
cleared for tests, but it wasn't being cleared for tests. Thus, there is no
reason for this attribute to be cached, so remove it.

Reviewed-By: Jacob Helwig <jacob@puppetlabs.com>

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUfac867c7bdbf: Remove Util::Cacher usage from SSL::CertificateAuthority
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Lewis <nick@puppetlabs.com> committed rPUbdcb9be3b5d7: Remove Puppet::Util::Cacher usage from Puppet::Util::Settings (authored by Nick Lewis <nick@puppetlabs.com>).Jul 22 2011, 5:10 AM