Revert "Merge pull request #2589 from daenney/add-ensure-type-logging"
This change added a lot of debugging information to every property
change made, which isn't needed for normal operation and clutters up the
output. In addition properties can define #is_to_s and #should_to_s
which can completely change how properties output change, so this change
by itself is somewhat misleading:
[root@master puppet]# bundle exec puppet resource file /root mode=0600 owner=vagrant group=vagrant Notice: /File[/root]/owner: owner changed 'root' of type Fixnum to 'vagrant' of type Fixnum Notice: /File[/root]/group: group changed 'root' of type Fixnum to 'vagrant' of type Fixnum Notice: /File[/root]/mode: mode changed '0550' of type String to '0700' of type String file { '/root': ensure => 'directory', group => '500', mode => '700', owner => '500', }
In this specific case https://github.com/puppetlabs/puppet/blob/3.6.1/lib/puppet/type/file/owner.rb#L34-L41
overrides the default is_to_s behavior, which indicates that this cannot
be done as a default and in fact should be up to the type author to
modify #is_to_s and #should_to_s as needed during debugging.
This reverts commit f89f1a536e22a04dc80a3b1c4c2d729693ce6b42, reversing
changes made to 34f55e1840b5dadadb84f95391a842a7b50a6540.