HomePhorge

(PUP-2710) Check that 'b' is a Time object before accessing tv_sec method
40024d87464cUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2710) Check that 'b' is a Time object before accessing tv_sec method

The initial fix checked that 'a' was a Time object but not that
'b' was a Time object - incorrectly reasoning that the code would
always compare like objects. However, when a property was previously
absent, the comparison might be between a Time object and the :absent
symbol. The fix is thus to check that both sides of the equality
comparison are Time objects first.

Details

Event Timeline

Kylo Ginsberg <kylo@puppetlabs.com> committed rPU40024d87464c: (PUP-2710) Check that 'b' is a Time object before accessing tv_sec method (authored by Kylo Ginsberg <kylo@puppetlabs.com>).Jun 5 2014, 7:15 AM