HomePhorge

(maint) Use correct data type when unscheduling events
376d498ecfc3Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(maint) Use correct data type when unscheduling events

Commit 9d59f204 added the ability to dequeue events on a given resource,
but it did so by setting the value of the target callbacks to an empty
hash. However the value of target callbacks is an array, so if events
were re-queued for a given resource we would get an error like so:

{}.concat(%w{one two three})
NoMethodError: undefined method `concat' for {}:Hash

Currently we can't requeue events after dequeuing events, but if this
changes then this code is very incorrect.

This commit fixes the event reset to behave as expected.

Details

Provenance
Adrien Thebo <git@somethingsinistral.net>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUaadc6245c014: (PUP-1106) Unschedule refreshes on skipped resources
Branches
Unknown
Tags
Unknown

Event Timeline

Adrien Thebo <git@somethingsinistral.net> committed rPU376d498ecfc3: (maint) Use correct data type when unscheduling events (authored by Adrien Thebo <git@somethingsinistral.net>).Sep 12 2014, 11:37 PM