HomePhorge

(#8660) Fix destdir option on Windows
328eaa2f7fd0Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#8660) Fix destdir option on Windows

Specifying the --destdir option failed on windows because the install
script attempted to concatenate two absolute paths together. On Unix,
this is fine, but on Windows, it fails because the colon (part of the
drive specifier) is not a valid filename character. This commit adds a
method to join two paths, stripping off the drive specifier, if
present.

Also fixed a minor bug, which caused a deprecation warning to always
be printed when the --destdir option is omitted, which is the default
case.

Reviewed-by: Cameron Thomas <cameron@puppetlabs.com>
(cherry picked from commit f6006177a85766cfb3387db6c3d337bf97b52f17)

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
Jacob Helwig <jacob@puppetlabs.com>Committed on Aug 19 2011, 10:52 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU088c7ac8632e: (#8660) Default config dir to %PROGRAMDATA% on Windows
Branches
Unknown
Tags
Unknown

Event Timeline

Jacob Helwig <jacob@puppetlabs.com> committed rPU328eaa2f7fd0: (#8660) Fix destdir option on Windows (authored by Josh Cooper <josh@puppetlabs.com>).Aug 19 2011, 10:52 PM