HomePhorge

(#8660) Fix destdir option on Windows
f6006177a857Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#8660) Fix destdir option on Windows

Specifying the --destdir option failed on windows because the install
script attempted to concatenate two absolute paths together. On Unix,
this is fine, but on Windows, it fails because the colon (part of the
drive specifier) is not a valid filename character. This commit adds a
method to join two paths, stripping off the drive specifier, if
present.

Also fixed a minor bug, which caused a deprecation warning to always
be printed when the --destdir option is omitted, which is the default
case.

Reviewed-by: Cameron Thomas <cameron@puppetlabs.com>

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU95b21dfde7d7: (#8660) Default config dir to %PROGRAMDATA% on Windows
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPUf6006177a857: (#8660) Fix destdir option on Windows (authored by Josh Cooper <josh@puppetlabs.com>).Jul 29 2011, 7:45 PM