Merge branch 'master' into puppet-4
- master: (23 commits) (PUP-2991) Add test case for user shell management (maint) Remove unused variable from directory.rb test (PUP-2991) Restore ability to manage shells on solaris (perf) Make small optimization to lexer by avoiding extra array (maint) Fix regression - negative string length came back after merge. (PUP-2860) Fix comments as pointed out in review (maint) Fix run of "empty catalog" benchmark missing current_environment (perf) Use faster polymorph lookup in bindings checker (maint) Remove extra abstraction PAbstractType - change to PAnyType (perf) freeze all string tokens at the source (in the lexer) (PUP-2860) Remove future parser's old lexer (perf) Make small adjustments to TypeCalculator (perf) Make small perf adjustments to TypeFactory (maint) Remove the unused class Visitor::Visitor2 (perf) Make a series of small nips and tucks wrt performance (PUP-2860) Remove repeated assert_rgen from other sources. (PUP-2860) Make injector transform using faster visitor call (PUP-2860) Make micro improvement by removing redundant checks (perf) Make micro improvement in getting exported/virtual status (perf) Make micro improvment by avoiding a method call for getting line ...