Page MenuHomePhorge
Feed Search

Aug 5 2024

machniak retitled D4869: Update mediasoup server and other meet server dependencies from Update mediasoupe server and other meet server dependencies
Aug 5 2024, 2:36 PM
machniak requested review of D4869: Update mediasoup server and other meet server dependencies.
Aug 5 2024, 2:01 PM
machniak committed rK2acc06ab0d89: Fix test.
Aug 5 2024, 7:22 AM
machniak committed R113:a25e48e2daec: Fix PHP5 compat..
Aug 5 2024, 7:09 AM
machniak committed R113:ed988390312e: Fix so install/update scripts do not require PEAR (#9037).
Aug 5 2024, 7:09 AM
machniak committed R113:36e747bd47cd: CI: Logs.
Aug 5 2024, 7:09 AM
machniak committed R113:1e503c768564: CI: Upload errors.log artifact.
Aug 5 2024, 7:09 AM
machniak committed R113:d1494f9f42b5: Fix phpunit compat..
Aug 5 2024, 7:09 AM
machniak committed R113:53da61f7fc8a: Fix information leak (access to remote content) via insufficient CSS filtering….
Aug 5 2024, 7:09 AM
machniak committed R113:c222ea8b9944: - Fix XSS vulnerability in serving of attachments other than HTML or SVG [CVE….
Aug 5 2024, 7:09 AM
machniak committed R113:1b3bb11d4f38: Fix XSS vulnerability in post-processing of sanitized HTML content [CVE-2024….
Aug 5 2024, 7:09 AM

Aug 2 2024

machniak updated the diff for D4866: OAuth fixes and tests.
  • Cleanup
Aug 2 2024, 1:39 PM
machniak updated the diff for D4866: OAuth fixes and tests.
  • OpenID-Connect implementation, OAuth improvements and tests
  • Enable .well-known/openid-configuration endpoint
  • Cleanup
Aug 2 2024, 9:51 AM

Jul 30 2024

machniak committed rS50e094543577: Fix PHP8 warnings.
Jul 30 2024, 11:47 AM

Jul 29 2024

machniak updated the diff for D4866: OAuth fixes and tests.
  • Fix test
Jul 29 2024, 1:45 PM
machniak requested review of D4866: OAuth fixes and tests.
Jul 29 2024, 12:29 PM

Jul 25 2024

machniak added a comment to D4854: First attempt to get oauth going.

BTW, I noted that some of your differentials cannot be easily used. arc patch returns "Base commit is not in local repository". Then I get:

Checking patch docker/synapse/rootfs/opt/app-root/src/init.sh...
error: docker/synapse/rootfs/opt/app-root/src/init.sh: does not exist in index
Checking patch docker/synapse/rootfs/opt/app-root/src/homeserver.yaml...
error: docker/synapse/rootfs/opt/app-root/src/homeserver.yaml: does not exist in index
Checking patch docker/synapse/Dockerfile...
error: docker/synapse/Dockerfile: does not exist in index
Checking patch config.prod/src/database/seeds/PassportSeeder.php...
Checking patch config.demo/src/database/seeds/PassportSeeder.php...
Checking patch ci/testctl...
Hunk #1 succeeded at 111 (offset -1 lines).
Checking patch ci/env...
error: while searching for:
MEET_SERVER_TOKEN=simple123
PASSPORT_PROXY_OAUTH_CLIENT_ID=5909ca4f-df7e-45fe-b355-e7c195aef117
PASSPORT_PROXY_OAUTH_CLIENT_SECRET=3URb+3JGJM9wPuDnlUSTPOw2mqmHsoOV8NXanx9xwQM=
DES_KEY=kBxUM/53N9p9abusAoT0ZEAxwI2pxFz/
Jul 25 2024, 8:09 AM · Restricted Project
machniak added a comment to D4854: First attempt to get oauth going.

I'm going to write tests.

Jul 25 2024, 7:09 AM · Restricted Project

Jul 24 2024

machniak committed rKda8e4454bfca: Data Migrator: Close IMAP connections cleanly.
Jul 24 2024, 11:56 AM
machniak requested review of D4863: Fix and unify checks for SoftDeletes capability on a model.
Jul 24 2024, 11:56 AM

Jul 23 2024

machniak committed rIacf0426c4739: Fix size=0 for uploaded files.
Jul 23 2024, 10:00 AM
machniak committed rI61e111c478ca: Fix PHP8 warning.
Jul 23 2024, 10:00 AM
machniak committed rCa1b82ce077f6: Fix PHP8 warnings.
Jul 23 2024, 9:53 AM
machniak committed rRPK102847604da5: Fix PHP8 warnings.
Jul 23 2024, 9:25 AM

Jul 22 2024

machniak requested review of D4860: MariaDB compatibility fix.
Jul 22 2024, 1:16 PM
machniak committed rS8bae1357be24: Small CS fixes.
Jul 22 2024, 12:50 PM
machniak committed rKfed7b8267e6d: Data Migrator: Cleanup jobs code.
Jul 22 2024, 11:21 AM
machniak closed D4857: Data Migrator: Improvements and tests.
Jul 22 2024, 9:50 AM
machniak committed rKa1f0d888441d: Data Migrator: Improvements and tests.
Jul 22 2024, 9:50 AM
machniak updated the diff for D4857: Data Migrator: Improvements and tests.
  • Better const name
Jul 22 2024, 9:48 AM
machniak requested review of D4857: Data Migrator: Improvements and tests.
Jul 22 2024, 9:46 AM

Jul 17 2024

machniak committed rKd3f874dd159b: EWS: Put X-MS-ID in the main VEVENT block.
Jul 17 2024, 12:41 PM
machniak committed rK5ce1c2d1b78a: Fix test regression.
Jul 17 2024, 11:24 AM
machniak committed rK76d38b70c9c8: Fix flaky test.
Jul 17 2024, 11:04 AM
machniak committed rK3b14529b0c25: Fix code style and small regression.
Jul 17 2024, 10:11 AM
machniak closed D4848: IMAP/DAV/EWS migrator improvements and tests.
Jul 17 2024, 9:42 AM
machniak committed rK50f6240db029: Cleanup.
Jul 17 2024, 9:42 AM
machniak committed rKfdb35bdfc18c: EWS: Improve distlist members handling.
Jul 17 2024, 9:42 AM
machniak committed rK642b4d497828: IMAP/DAV/EWS migrator improvements and tests.
Jul 17 2024, 9:42 AM

Jul 16 2024

machniak updated the diff for D4848: IMAP/DAV/EWS migrator improvements and tests.
  • EWS: Fix some contact properties in exported vCard
  • EWS: Fix lists handling
  • EWS: Improved tasks handling
Jul 16 2024, 2:26 PM

Jul 15 2024

machniak added a comment to D4851: Attempted to support bcc via eas 16.0.

Nope. If you do this the header will be send to every recipient. Note that we're unsetting the header in $smtp_headers only here. The copy of the message saved to Sent folder should contain Bcc header intact.

Jul 15 2024, 1:38 PM
machniak closed T8382: Debian12: warning in kolab-webadmin as Resolved.

Thanks. Fixed.

Jul 15 2024, 11:06 AM · Bug Reports
machniak committed rWAP0bbdc61c53b3: Fix PHP deprecation warning (T8382).
Jul 15 2024, 11:06 AM
machniak requested review of D4848: IMAP/DAV/EWS migrator improvements and tests.
Jul 15 2024, 10:48 AM

Jul 8 2024

machniak closed D4842: Sync Calendars first.
Jul 8 2024, 1:35 PM
machniak committed rS75a0b664346f: Sync Calendars first.
Jul 8 2024, 1:35 PM
machniak closed D4845: IMAP data migrator and other improvements.
Jul 8 2024, 6:12 AM
machniak committed rK21d3bcab8719: IMAP data migrator and other improvements.
Jul 8 2024, 6:12 AM

Jul 7 2024

machniak added a comment to D4827: IMAP and DAV migration.

In D4845: IMAP data migrator and other improvements I took this differential of yours, but I re-implemented some things differently. I think it's cleaner. Still a lot of TODO lines there. So, we might improve while writing tests. I have also an idea to try to do mail streaming for best performance.

Jul 7 2024, 8:18 AM
machniak requested review of D4845: IMAP data migrator and other improvements.
Jul 7 2024, 8:11 AM

Jul 5 2024

machniak added a comment to D4839: Ignore iTip parsing errors when synchronizing mail.

Throwable catches that fatal error. Now looking at this I found that we could change the catch in https://git.kolab.org/diffusion/RPK/browse/master/plugins/libcalendaring/lib/libcalendaring_vcalendar.php$158

Jul 5 2024, 10:00 AM
machniak updated the diff for D4842: Sync Calendars first.
  • It's a debug not a warning
Jul 5 2024, 9:48 AM
machniak updated the diff for D4842: Sync Calendars first.
  • Move sorting to later place
Jul 5 2024, 9:47 AM
machniak updated the diff for D4842: Sync Calendars first.
  • Fix sorting callback
Jul 5 2024, 9:03 AM
machniak updated the diff for D4842: Sync Calendars first.
  • Fix sign
Jul 5 2024, 8:25 AM
machniak requested review of D4842: Sync Calendars first.
Jul 5 2024, 8:15 AM

Jul 4 2024

machniak closed D4836: Incremental migration EWS -> DAV.
Jul 4 2024, 1:07 PM
machniak committed rK4de395e830c9: Incremental migration EWS -> DAV.
Jul 4 2024, 1:07 PM
machniak added a comment to D4839: Ignore iTip parsing errors when synchronizing mail.

Indeed. I just noticed that the actual error wasn't an exception. It was PHP Fatal error: Uncaught Error: __clone method called on non-object in /usr/share/roundcubemail/plugins/libcalendaring/lib/libcalendaring_vcalendar.php:633, so to catch it we'd have to catch Throwable, I suppose, I'm not sure.

Jul 4 2024, 11:51 AM
machniak closed D4818: Send QR-code content also plain text.
Jul 4 2024, 10:28 AM
machniak closed D4821: Use Laravel HTTP client in CompanionApp.
Jul 4 2024, 10:28 AM
machniak committed rK3407cd0a8367: Use Laravel HTTP client in CompanionApp.
Jul 4 2024, 10:28 AM
machniak committed rK356c7abbf687: Send QR-code content also plain text.
Jul 4 2024, 10:28 AM
machniak updated the diff for D4839: Ignore iTip parsing errors when synchronizing mail.
  • phpdoc
Jul 4 2024, 10:27 AM
machniak requested review of D4839: Ignore iTip parsing errors when synchronizing mail.
Jul 4 2024, 10:19 AM
machniak closed D4830: Add --tenant option where needed.
Jul 4 2024, 9:59 AM
machniak closed D4833: Use Laravel HTTP client for Meet connections.
Jul 4 2024, 9:59 AM
machniak committed rKf774cc5f8fb9: Use Laravel HTTP client for Meet connections.
Jul 4 2024, 9:59 AM
machniak committed rK870e7b0d2ebf: Add --tenant option where needed.
Jul 4 2024, 9:59 AM
machniak updated the diff for D4836: Incremental migration EWS -> DAV.
  • Missing DAV/Search
Jul 4 2024, 9:52 AM
machniak requested review of D4836: Incremental migration EWS -> DAV.
Jul 4 2024, 9:51 AM

Jul 3 2024

machniak added a comment to D4827: IMAP and DAV migration.

Good progress, but I was about to work on DAV, and I already have some conflicting code. Please, don't work on DAV at this moment.

Jul 3 2024, 4:25 PM
machniak added a comment to T8376: Debian 11: warning in /usr/share/php/HTTP/Request2.php.

Short term, we should update the php-http-request2 package. 2.6.0 supports PHP >= 5.6 still, so there's no issue with that.

Jul 3 2024, 7:59 AM · Bug Reports
machniak requested review of D4833: Use Laravel HTTP client for Meet connections.
Jul 3 2024, 7:28 AM

Jul 2 2024

machniak committed rRPK398c3120e83d: Add missing test file.
Jul 2 2024, 10:25 AM
machniak committed rRPK8f88b4b12086: Fix fatal error when parsing VEVENT without DTSTART.
Jul 2 2024, 10:22 AM
machniak committed rRPK1345402bb9ec: Fix tests using Roundcube master.
Jul 2 2024, 9:56 AM
machniak closed D4824: Data migration tool.
Jul 2 2024, 9:20 AM
machniak committed rKfd6cc6b72094: Data migration tool.
Jul 2 2024, 9:20 AM
machniak requested review of D4830: Add --tenant option where needed.
Jul 2 2024, 9:14 AM

Jul 1 2024

machniak added inline comments to D4827: IMAP and DAV migration.
Jul 1 2024, 4:03 PM
machniak added inline comments to D4824: Data migration tool.
Jul 1 2024, 11:05 AM
machniak committed rK7fddf799e548: Fix a couple of PHPCS issues.
Jul 1 2024, 10:08 AM
machniak requested review of D4824: Data migration tool.
Jul 1 2024, 9:31 AM

Jun 28 2024

machniak updated the diff for D4659: Init default DAV folders.
  • Merge branch 'master' into dev/dav-folders-init
Jun 28 2024, 6:21 AM
machniak committed rKfd9c8076be1c: Add folder management methods to the DAV client.
Jun 28 2024, 6:13 AM
machniak updated the diff for D4821: Use Laravel HTTP client in CompanionApp.
  • Small improvements
Jun 28 2024, 6:05 AM
machniak updated the diff for D4821: Use Laravel HTTP client in CompanionApp.
  • Fix case
Jun 28 2024, 6:02 AM
machniak updated the diff for D4821: Use Laravel HTTP client in CompanionApp.
  • Remove unused $response variable
Jun 28 2024, 6:00 AM
machniak requested review of D4821: Use Laravel HTTP client in CompanionApp.
Jun 28 2024, 5:59 AM

Jun 27 2024

machniak requested review of D4818: Send QR-code content also plain text.
Jun 27 2024, 4:24 PM
machniak requested changes to D4815: Add the list to the admin panel as well.
Jun 27 2024, 10:57 AM

Jun 26 2024

machniak committed rK702d39673002: Re-fix the test.
Jun 26 2024, 12:30 PM
machniak committed rKdd670e2c881a: Fix phpstan errors.
Jun 26 2024, 12:26 PM
machniak committed rK382264bb3fdd: Fix tenant option in data:import:signup-tokens command.
Jun 26 2024, 12:26 PM
machniak added inline comments to D4812: Limit profit by wallet balance.
Jun 26 2024, 8:34 AM

Jun 25 2024

machniak added inline comments to D4812: Limit profit by wallet balance.
Jun 25 2024, 9:36 AM

Jun 24 2024

machniak closed D4701: Fix error on arabic date input.
Jun 24 2024, 3:41 PM
machniak committed rS7dd6f93097e8: Fix error on arabic date input.
Jun 24 2024, 3:41 PM
machniak closed D4794: Fold WalletCharge and WalletCheck into one.
Jun 24 2024, 12:54 PM