Page MenuHomePhorge
Feed Search

Sep 11 2025

machniak requested changes to D5586: imap:copy and imap:subscribe commands.
Sep 11 2025, 8:34 AM
machniak accepted D5583: Fix non-get redirects.
Sep 11 2025, 8:22 AM
machniak accepted D5580: Remove the linter extension.

Yeah, for me neither.

Sep 11 2025, 8:20 AM
machniak added a comment to D5565: Get GroupsTest/ResourceTest/SharedFoldersTest to pass.

Maybe DNS does not work in your environment. These tests work fine for me.

Sep 11 2025, 8:20 AM
machniak accepted D5595: LDAP commands.
Sep 11 2025, 8:10 AM
machniak accepted D5598: Avoid configuring kolab_notes in kolab4 groupware mode.
Sep 11 2025, 7:48 AM

Sep 10 2025

machniak requested review of D5577: More API docs - refactoring and cleanup.
Sep 10 2025, 1:46 PM
machniak committed R114:bd2b23912aa6: Small doc improvements.
Sep 10 2025, 9:11 AM

Sep 8 2025

machniak closed D5574: API documentation using Scramble.
Sep 8 2025, 9:00 AM
machniak committed rKe648648e96eb: API documentation using Scramble.
Sep 8 2025, 9:00 AM

Sep 5 2025

machniak updated the diff for D5574: API documentation using Scramble.
  • Use array shapes
Sep 5 2025, 1:37 PM
machniak updated the diff for D5574: API documentation using Scramble.
  • Rename
Sep 5 2025, 1:13 PM
machniak updated the diff for D5574: API documentation using Scramble.
  • Improved AuthController docs
  • More API docs
  • More API docs, fixed regressions
Sep 5 2025, 1:08 PM

Sep 4 2025

machniak updated the diff for D5574: API documentation using Scramble.
  • Hide not implemented routes
  • API docs
Sep 4 2025, 2:16 PM
machniak updated the diff for D5574: API documentation using Scramble.
  • API docs
Sep 4 2025, 10:58 AM
machniak updated the diff for D5574: API documentation using Scramble.
  • Introduce PlanResource, add 'plans' to device info response
Sep 4 2025, 8:10 AM

Sep 3 2025

machniak updated the diff for D5574: API documentation using Scramble.
  • Fix regressions, more api docs for the SignupController
Sep 3 2025, 2:42 PM
machniak planned changes to D5574: API documentation using Scramble.

There's some regressions I'm working on fixing.

Sep 3 2025, 1:27 PM
machniak requested review of D5574: API documentation using Scramble.
Sep 3 2025, 11:41 AM

Sep 1 2025

machniak committed rK523ceec467e7: CS fix.
Sep 1 2025, 11:38 AM
machniak committed rK5bf9adaf5601: Change scalpel:folder:* into scalpel:shared-folder:* for consistency with other….
Sep 1 2025, 11:36 AM
machniak accepted D5571: Fixed setting activesync_debug.

I think for Roundcube and most other services the startup hook is early enough. Of course, the logon phase is a separate problem, as we need an authenticated user to get the config from cockpit.

Sep 1 2025, 11:31 AM
machniak closed D5568: Device registration.
Sep 1 2025, 10:55 AM
machniak committed rKc24021bbefb0: Device registration.
Sep 1 2025, 10:54 AM

Aug 29 2025

machniak requested review of D5568: Device registration.
Aug 29 2025, 6:49 AM

Aug 25 2025

machniak committed rK833828523f41: Test improvement.
Aug 25 2025, 1:22 PM
machniak closed D5559: Sender access policy for distlist mail delivery.
Aug 25 2025, 11:45 AM
machniak committed rK7a8b6013ba77: Sender access policy for distlist mail delivery.
Aug 25 2025, 11:45 AM
machniak accepted D5562: Ensure that nothing other than INBOX ever receives the inbox type.
Aug 25 2025, 11:44 AM
machniak added a comment to rRPKf2b7e69fa53d: kolab_folders: Don't set subtype on a new folder by default.

I guess, separately we should make sure user does not do something stupid when the form is submitted. I.e. he can still manually set mail.inbox to any subfolder. But that's a separate issue.

Aug 25 2025, 10:54 AM
machniak committed rRPKf2b7e69fa53d: kolab_folders: Don't set subtype on a new folder by default.
Aug 25 2025, 10:40 AM
machniak requested review of D5559: Sender access policy for distlist mail delivery.
Aug 25 2025, 10:19 AM
machniak closed D5556: Fix mail delivery for distlists and shared folders.
Aug 25 2025, 8:47 AM
machniak committed rK6c913902adde: Fix mail delivery for distlists and shared folders.
Aug 25 2025, 8:47 AM
machniak closed D5550: Force organizer on an event exception to match the master event organizer.
Aug 25 2025, 8:46 AM
machniak committed rK22b1c0200482: Force organizer on an event exception to match the master event organizer.
Aug 25 2025, 8:46 AM

Aug 22 2025

machniak updated the diff for D5556: Fix mail delivery for distlists and shared folders.
  • Remove wrong TODO comments
Aug 22 2025, 12:05 PM
machniak requested review of D5556: Fix mail delivery for distlists and shared folders.
Aug 22 2025, 10:00 AM

Aug 20 2025

machniak accepted D5553: Publish swoole metrics without access control.

Using ->withoutMiddleware(['allowedHosts']) would be shorter, but I'm not sure which I'd prefer here.

Aug 20 2025, 8:32 AM
machniak committed rKafea2cda0d20: CS fix.
Aug 20 2025, 8:17 AM

Aug 19 2025

machniak requested review of D5550: Force organizer on an event exception to match the master event organizer.
Aug 19 2025, 1:02 PM

Aug 18 2025

machniak committed rRPK0325c3912755: Allow kolab_users_name_field=false to disable UID-to-name resolving.
Aug 18 2025, 9:25 AM

Aug 14 2025

machniak committed rRPK60b9665112ef: Small code improvement.
Aug 14 2025, 8:09 AM

Aug 11 2025

machniak closed D5547: Controllers rights review.
Aug 11 2025, 12:43 PM
machniak committed rK6ba921f44948: Controllers rights review.
Aug 11 2025, 12:43 PM
machniak closed D5511: iTip spoofing protection.
Aug 11 2025, 12:10 PM
machniak committed rK02728a111737: iTip spoofing protection.
Aug 11 2025, 12:10 PM

Aug 8 2025

machniak updated the diff for D5547: Controllers rights review.
  • Hide Wallet and Policy in the Dashboard for wallet controllers that aren't owners
Aug 8 2025, 11:47 AM
machniak updated the diff for D5547: Controllers rights review.
  • Enable wallet controllers to create users
  • Enable wallet controllers to create shared folders
  • Enable wallet controllers to create groups
  • Enable wallet controllers to create domains
  • Make wallet controllers able to create resources
Aug 8 2025, 11:31 AM
machniak requested review of D5547: Controllers rights review.
Aug 8 2025, 8:04 AM

Aug 6 2025

machniak requested review of D5544: Activesync: An option to disable UID resolving on folders list.
Aug 6 2025, 10:32 AM
machniak accepted D5478: Simplify domain verification instructions.
Aug 6 2025, 9:13 AM

Aug 1 2025

machniak updated the diff for D5511: iTip spoofing protection.
  • iTip Delegation
Aug 1 2025, 1:38 PM

Jul 30 2025

machniak updated the diff for D5511: iTip spoofing protection.
  • iTip REQUEST notifications
  • Tests
Jul 30 2025, 1:09 PM

Jul 29 2025

machniak updated the diff for D5511: iTip spoofing protection.
  • Small refactoring
  • Refactor
  • Check recipient in a REQUEST
  • Cleanup
Jul 29 2025, 11:44 AM

Jul 28 2025

machniak updated the diff for D5511: iTip spoofing protection.
  • Cleanup FIXME/TODO comments
  • Proper SEQUENCE handling with tests
Jul 28 2025, 1:38 PM
machniak added inline comments to D5535: Domain validity check.
Jul 28 2025, 1:11 PM
machniak requested changes to D5541: Imap commands to delete groupware mailboxes.

I would probably not incorporate an obsolete features into an existing code, but ok.

Jul 28 2025, 12:51 PM
machniak accepted D5529: Get dav migration over http to work.
Jul 28 2025, 12:44 PM
machniak requested changes to D5526: Settings commands.
Jul 28 2025, 12:41 PM
machniak accepted D5532: Don't abort migration on 403 errors.

I wonder if 403 in other circumstances would not be more generic. E.g. authentication issue.

Jul 28 2025, 12:35 PM
machniak accepted D5382: Expose some swoole metrics.
Jul 28 2025, 12:28 PM
machniak requested changes to D5535: Domain validity check.
Jul 28 2025, 12:27 PM
machniak accepted D5523: Dav backend switching based on auth request and kolabobjects_storage setting.
Jul 28 2025, 12:23 PM
machniak accepted D5520: Record the http status code.
Jul 28 2025, 12:15 PM
machniak added a comment to D5517: Instead of restricting over which domains we can access services, we restrict over which we cannot (the public ones)..

This is kinda mess. Maybe a better approach would be to just check that the request comes from the "internal" location? E.g. by having list of IP networks (or IPs). But that potentially may be more complicated. Another possibility, a "client secret", but this probably would be event more problematic.

Jul 28 2025, 12:13 PM
machniak requested changes to D5382: Expose some swoole metrics.
Jul 28 2025, 11:49 AM
machniak accepted D5514: Pin octane 2.11.
Jul 28 2025, 9:48 AM
machniak requested review of D5511: iTip spoofing protection.
Jul 28 2025, 9:09 AM

Jul 25 2025

machniak closed D5508: Fix an error in greylisting for a SharedFolder or Resource recipient.
Jul 25 2025, 10:08 AM
machniak committed rK45ad2c871a1a: Fix an error in greylisting for a SharedFolder or Resource recipient.
Jul 25 2025, 10:08 AM
machniak requested review of D5508: Fix an error in greylisting for a SharedFolder or Resource recipient.
Jul 25 2025, 8:50 AM

Jul 22 2025

machniak closed D5469: Kolab: User debug mode.
Jul 22 2025, 9:58 AM
machniak committed rRPK49bd386681a2: Kolab: User debug mode.
Jul 22 2025, 9:58 AM

Jul 21 2025

machniak closed D5472: User debug mode.
Jul 21 2025, 1:41 PM
machniak committed rKd82f41a43101: User debug mode.
Jul 21 2025, 1:41 PM
machniak closed D5427: Slim down number of wallet check jobs.
Jul 21 2025, 1:41 PM
machniak committed rK15f17f1a4193: Slim down number of wallet check jobs.
Jul 21 2025, 1:41 PM
machniak closed D5505: Optimized way of using X-Client-IP header.
Jul 21 2025, 1:41 PM
machniak committed rK56b14dd00ea5: Optimized way of using X-Client-IP header.
Jul 21 2025, 1:41 PM
machniak closed D5502: Mailfilter improvements.
Jul 21 2025, 1:41 PM
machniak committed rK6214504f503b: Mailfilter improvements.
Jul 21 2025, 1:41 PM

Jul 18 2025

machniak requested review of D5505: Optimized way of using X-Client-IP header.
Jul 18 2025, 12:39 PM
machniak requested review of D5502: Mailfilter improvements.
Jul 18 2025, 11:37 AM

Jul 17 2025

machniak updated the diff for D5499: Add useful views definition.
  • Use lower-case queries for consistency with the rest
Jul 17 2025, 1:22 PM
machniak requested review of D5499: Add useful views definition.
Jul 17 2025, 1:21 PM
machniak closed D5496: Itip: Fix handling REQUEST to an existing event.
Jul 17 2025, 11:48 AM
machniak committed rKb04a0f2767c9: Itip: Fix handling REQUEST to an existing event.
Jul 17 2025, 11:48 AM
machniak updated the diff for D5472: User debug mode.
  • Add user:debug-start and user:debug-stop commands
Jul 17 2025, 11:34 AM

Jul 16 2025

machniak requested review of D5496: Itip: Fix handling REQUEST to an existing event.
Jul 16 2025, 10:08 AM
machniak committed rK51a910fb9a05: CS fix.
Jul 16 2025, 8:14 AM
machniak requested changes to D5490: Use a header instead of http status codes for the mailfilter.

Nitpicking.

Jul 16 2025, 5:45 AM
machniak abandoned D5481: Use mail queue for ItipNotifications.
Jul 16 2025, 5:40 AM
machniak accepted D5493: Use mail queue for notifications.
Jul 16 2025, 5:39 AM

Jul 15 2025

machniak added a comment to D5490: Use a header instead of http status codes for the mailfilter.

It makes it more standard if we use 204 when the reply is indeed empty. So, it might make sense to use both 200 and 204 according to the response body being empty or not. Also, the header name might be better as X-Kolab-Mailfilter-Action.

Jul 15 2025, 4:12 PM
machniak added a comment to D5487: Allow service accounts to impersonate local users.

probably needs a test adjusted someplace.

Jul 15 2025, 1:32 PM
machniak committed rK2b6192e31e56: Fix test regression.
Jul 15 2025, 1:30 PM
machniak requested review of D5484: noreply@ user can impersonate everyone.
Jul 15 2025, 1:00 PM
machniak closed D5433: Make sure that user data is deleted in user:force-delete command.
Jul 15 2025, 12:48 PM
machniak committed rKf8cbb1ac776e: Make sure that user data is deleted in user:force-delete command.
Jul 15 2025, 12:48 PM