Page MenuHomePhorge
Differential D429

Fixed the case where all entries of a single packet are filtered
ClosedPublic
Actions

Authored by mollekopf on Apr 28 2017, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 29, 1:32 PM
Unknown Object (File)
Wed, May 29, 11:45 AM
Unknown Object (File)
Tue, May 28, 6:03 AM
Unknown Object (File)
Tue, May 21, 6:13 AM
Unknown Object (File)
Apr 27 2024, 9:02 AM
Unknown Object (File)
Apr 26 2024, 8:39 PM
Unknown Object (File)
Apr 26 2024, 6:12 PM
Unknown Object (File)
Apr 20 2024, 12:54 PM
View All Files
Subscribers
None

Details

Reviewers
• seigo
vanmeeuwen
Commits
rGdeb3292b33ae: Fixed the case where all entries of a single packet are filtered
rG0849a45cb179: Fixed the case where all entries of a single packet are filtered
Summary

According to idea from original patch by vanmeeuwen

Test Plan

Test passes

Diff Detail

Repository
rG guam
Branch
arcpatch-D429
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9507
Build 9111: arc lint + arc unit

Event Timeline

mollekopf created this revision.Apr 28 2017, 4:18 PM
mollekopf updated this revision to Diff 975.May 2 2017, 10:46 AM

Implemented changerequests

apps/kolab_guam/src/rules/kolab_guam_rule_filter_groupware.erl
91

would prefer something like:

{ possibly_append_newline(Response), State#state { active = More, last_chunk = LastChunk } }.

possibly_append_newline(

mollekopf marked an inline comment as done.May 2 2017, 10:47 AM
Closed by commit rG0849a45cb179: Fixed the case where all entries of a single packet are filtered (authored by Christian Mollekopf <chrigi_1@fastmail.fm>). · Explain WhyMay 2 2017, 4:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
apps/
kolab_guam/
src/
rules/
5 lines
test/
11 lines

Diff 975

View Options

apps/kolab_guam/src/rules/kolab_guam_rule_filter_groupware.erl

Loading...
View Options

apps/kolab_guam/test/kolab_guam_rules_SUITE.erl

Loading...