Fixed the case where all entries of a single packet are filtered
ClosedPublic
Actions

Authored by mollekopf on Apr 28 2017, 4:18 PM.

Tags

None

Referenced Files

	F11824980: D429.id969.diff
	Sat, Apr 20, 12:54 PM

	F11811825: D429.id975.diff
	Fri, Apr 19, 5:11 PM

	Unknown Object (File)
	Sat, Apr 13, 7:57 AM

	Unknown Object (File)
	Fri, Apr 12, 10:18 AM

	Unknown Object (File)
	Sun, Apr 7, 3:40 PM

	Unknown Object (File)
	Sat, Apr 6, 4:05 PM

	Unknown Object (File)
	Sun, Mar 31, 9:26 PM

	Unknown Object (File)
	Thu, Mar 28, 8:45 PM

View All Files

Subscribers

None

Details

Reviewers

• seigo
vanmeeuwen

Commits

rGdeb3292b33ae: Fixed the case where all entries of a single packet are filtered
rG0849a45cb179: Fixed the case where all entries of a single packet are filtered

Summary

According to idea from original patch by vanmeeuwen

Test Plan

Test passes

Diff Detail

Repository

rG guam

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf created this revision.Apr 28 2017, 4:18 PM

Implemented changerequests

apps/kolab_guam/src/rules/kolab_guam_rule_filter_groupware.erl
94–95	would prefer something like: { possibly_append_newline(Response), State#state { active = More, last_chunk = LastChunk } }. possibly_append_newline(

mollekopf marked an inline comment as done.May 2 2017, 10:47 AM

Closed by commit rG0849a45cb179: Fixed the case where all entries of a single packet are filtered (authored by Christian Mollekopf <chrigi_1@fastmail.fm>). · Explain WhyMay 2 2017, 4:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

apps/

kolab_guam/

src/

rules/

kolab_guam_rule_filter_groupware.erl

9 lines

test/

kolab_guam_rules_SUITE.erl

11 lines

Diff 987

View Options

apps/kolab_guam/src/rules/kolab_guam_rule_filter_groupware.erl