Paths

Table of Contentst

Differential D3241

[Python 3] Get rid of .has_key()
ClosedPublic
Actions

Authored by sicherha on Jan 8 2022, 11:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 12, 8:44 PM

	Unknown Object (File)
	Fri, Mar 29, 12:20 PM

	Unknown Object (File)
	Thu, Mar 28, 6:44 AM

	Unknown Object (File)
	Wed, Mar 27, 1:57 AM

	Unknown Object (File)
	Tue, Mar 26, 1:46 AM

	Unknown Object (File)
	Mar 5 2024, 3:06 PM

	Unknown Object (File)
	Mar 1 2024, 3:34 PM

	Unknown Object (File)
	Feb 14 2024, 11:55 PM

View All 33 Files

Subscribers

None

Details

Reviewers

machniak
mollekopf

Commits

rP9a5f92139d3f: [Python 3] Get rid of .has_key()

Summary

dict.has_key(key) was dropped in Python 3.0. Use key in dict
instead.

Diff Detail

Repository

Branch

06-remove-has_key

Lint

Lint Errors

Severity	Location	Code	Message
Error	cyruslib.py:43	E203	PEP8 E203
Error	cyruslib.py:44	E203	PEP8 E203
Error	cyruslib.py:45	E203	PEP8 E203
Error	cyruslib.py:48	E203	PEP8 E203
Error	cyruslib.py:76	E701	PEP8 E701
Error	cyruslib.py:88	E701	PEP8 E701
Error	cyruslib.py:107	E701	PEP8 E701
Error	cyruslib.py:401	E701	PEP8 E701
Error	cyruslib.py:512	E701	PEP8 E701
Error	cyruslib.py:529	E701	PEP8 E701
Error	cyruslib.py:531	E701	PEP8 E701
Error	cyruslib.py:800	E701	PEP8 E701
Error	cyruslib.py:814	E701	PEP8 E701
Error	cyruslib.py:816	E701	PEP8 E701
Error	pykolab/auth/ldap/syncrepl.py:75	E701	PEP8 E701
Error	pykolab/auth/ldap/syncrepl.py:76	E701	PEP8 E701
Error	pykolab/cli/cmd_sync.py:77	E111	PEP8 E111
Error	pykolab/cli/cmd_sync.py:78	E111	PEP8 E111
Error	pykolab/cli/cmd_sync.py:79	E111	PEP8 E111
Error	pykolab/cli/cmd_sync.py:80	E111	PEP8 E111
Error	pykolab/cli/cmd_sync.py:81	E111	PEP8 E111
Error	pykolab/cli/cmd_sync.py:89	E111	PEP8 E111
Error	pykolab/cli/cmd_sync.py:90	E111	PEP8 E111
Error	pykolab/cli/sieve/cmd_refresh.py:377	E203	PEP8 E203
Error	pykolab/plugins/sievemgmt/__init__.py:387	E203	PEP8 E203

Unit

No Test Coverage

Build Status

Buildable 37789
Build 15238: arc lint + arc unit

Event Timeline

sicherha requested review of this revision.Jan 8 2022, 11:39 AM

sicherha created this revision.

Harbormaster completed remote builds in B37789: Diff 9205.Jan 8 2022, 11:39 AM

sicherha mentioned this in D3190: Python 3 compatibility.Jan 8 2022, 11:42 AM

sicherha mentioned this in T6805: Port pykolab to Python 3.Jan 8 2022, 11:45 AM

mollekopf accepted this revision.Jan 10 2022, 10:07 AM

This revision is now accepted and ready to land.Jan 10 2022, 10:07 AM

This revision was landed with ongoing or failed builds.Jan 10 2022, 8:50 PM

Closed by commit rP9a5f92139d3f: [Python 3] Get rid of .has_key() (authored by sicherha). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

2 lines

ext/

python/

Tools/

freeze/

checkextensions.py

4 lines

pykolab/

auth/

ldap/

2 lines

cli/

6 lines

cmd_add_alias.py

4 lines

cmd_list_mailbox_metadata.py

2 lines

2 lines

16 lines

sieve/

22 lines

imap/

6 lines

plugins/

defaultfolders/

2 lines

dynamicquota/

2 lines

recipientpolicy/

10 lines

roundcubedb/

2 lines

sievemgmt/

24 lines

setup/

2 lines

16 lines

10 lines

wap_client/

18 lines

xml/

10 lines

8 lines

24 lines

4 lines

recurrence_rule.py

10 lines

20 lines

20 lines

wallace/

module_gpgencrypt.py

2 lines

module_invitationpolicy.py

36 lines

module_optout.py

2 lines

6 lines

Diff 9205

cyruslib.py

Loading...

ext/python/Tools/freeze/checkextensions.py

Loading...

pykolab/auth/ldap/syncrepl.py

Loading...

pykolab/cli/init.py

Loading...

pykolab/cli/cmd_add_alias.py

Loading...

pykolab/cli/cmd_list_mailbox_metadata.py

Loading...

pykolab/cli/cmd_sync.py

Loading...

pykolab/cli/commands.py

Loading...

pykolab/cli/sieve/cmd_refresh.py

Loading...

pykolab/imap/cyrus.py

Loading...

pykolab/plugins/defaultfolders/init.py

Loading...

pykolab/plugins/dynamicquota/init.py

Loading...

pykolab/plugins/recipientpolicy/init.py

Loading...

pykolab/plugins/roundcubedb/init.py

Loading...

pykolab/plugins/sievemgmt/init.py

Loading...

pykolab/setup/init.py

Loading...

pykolab/setup/components.py

Loading...

pykolab/translit.py

Loading...

pykolab/wap_client/init.py

Loading...

pykolab/xml/attendee.py

Loading...

pykolab/xml/contact.py

Loading...

pykolab/xml/event.py

Loading...

pykolab/xml/note.py

Loading...

pykolab/xml/recurrence_rule.py

Loading...

pykolab/xml/todo.py

Loading...

pykolab/xml/utils.py

Loading...

wallace/module_gpgencrypt.py

Loading...

wallace/module_invitationpolicy.py

Loading...

wallace/module_optout.py

Loading...

wallace/modules.py

Loading...