./phpunit
Details
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rKa7cd372f8179: Shared folders
rK9da1d8fde793: Shared folders
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/shared-folders
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 37250 Build 14900: arc lint + arc unit
Event Timeline
Comment Actions
- Re-title shared_folders SKU to shared-folders for consistency with others
- Make phpstan happy
- Make phpstan happy, now we're green
Comment Actions
Looks good aside from the non-blocking comments.
| src/app/Http/Controllers/API/V4/PaymentsController.php | ||
|---|---|---|
| 170 | This doesn't belong in this patch I think. | |
| src/app/SharedFolder.php | ||
| 1 | Perhaps a Resource should become a SharedFolder (via inheritance directly, or perhaps via a baseclass to avoid including the wrong traits),? Otherwise we just duplicate code. | |
Comment Actions
From manual testing it seems to me that a new shared folder never makes it out of the "Not Ready" state.
The controller is repeatedly queried for a status update, but the code never checks back in imap/ldap after initially failing on a GETMETADATA command (when creating the folder).
The only way to get it active is to wait for a Refresh button to appear (after a pretty long timeout), pressing it immediately turns it to active.
Could be that it fixes itself when waiting for longer, but from a UX perspective it's not ideal (but perhaps just a later enhancement).