Paths

Table of Contentst

Differential D3002

Group: Sender policy
ClosedPublic
Actions

Authored by machniak on Nov 5 2021, 2:57 PM.

Tags

None

Referenced Files

	F12228129: D3002.diff
	Sat, May 18, 10:14 AM

	Unknown Object (File)
	Wed, May 8, 11:04 PM

	Unknown Object (File)
	Wed, May 1, 7:14 AM

	Unknown Object (File)
	Wed, May 1, 7:14 AM

	Unknown Object (File)
	Wed, May 1, 7:14 AM

	Unknown Object (File)
	Wed, May 1, 7:14 AM

	Unknown Object (File)
	Wed, May 1, 7:14 AM

	Unknown Object (File)
	Tue, Apr 30, 11:10 AM

View All 69 Files

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rKa5633ffad441: Group: Sender policy

Test Plan

./phpunit

Diff Detail

Repository

Branch

dev/group-smtp-sender-policy

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 37004
Build 14750: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Nov 5 2021, 2:57 PM

machniak created this revision.

Harbormaster completed remote builds in B36995: Diff 8555.Nov 5 2021, 2:57 PM

Display sender policy in admin/reseller UI

Harbormaster completed remote builds in B37004: Diff 8567.Nov 8 2021, 9:39 AM

Looks good to me aside from the UI text which I think could be a bit clearer.

src/database/migrations/2021_11_05_100000_create_group_settings_table.php
23	This is a string in the user_settings table, I assume we need to store larger values here?
src/resources/lang/en/ui.php
62	Suggestion: With this list you can specify who can send mail to the distribution list." . " You can put a complete email address (jane@kolab.org), domain (kolab.org) or suffix (.org) that the sender email address is be compared to." . " If the list is empty, mail from anyone is allowed.

machniak added inline comments.Nov 8 2021, 10:23 AM

src/database/migrations/2021_11_05_100000_create_group_settings_table.php
23	It was a string initially, but later on changed to text. So, this is consistent, the default 'string' column length is not enough, indeed.
src/resources/lang/en/ui.php
62	Thx, I'll change that.

mollekopf accepted this revision.Nov 8 2021, 10:52 AM

This revision is now accepted and ready to land.Nov 8 2021, 10:52 AM

Small wording improvement

Harbormaster completed remote builds in B37010: Diff 8573.Nov 8 2021, 11:06 AM

Closed by commit rKa5633ffad441: Group: Sender policy (authored by machniak). · Explain WhyNov 9 2021, 3:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Backends/

13 lines

10 lines

4 lines

GroupSetting.php

30 lines

Http/

Controllers/

API/

V4/

DomainsController.php

2 lines

GroupsController.php

34 lines

UsersController.php

2 lines

Observers/

GroupSettingObserver.php

51 lines

Providers/

AppServiceProvider.php

1 line

10 lines

Traits/

GroupConfigTrait.php

70 lines

SettingsTrait.php

10 lines

10 lines

10 lines

database/

migrations/

2021_11_05_100000_create_group_settings_table.php

44 lines

resources/

lang/

en/

1 line

4 lines

1 line

vue/

Admin/

29 lines

2 lines

Distlist/

79 lines

routes/

3 lines

tests/

Browser/

Admin/

DistlistTest.php

8 lines

Components/

6 lines

DistlistTest.php

61 lines

Pages/

Admin/

2 lines

DistlistInfo.php

6 lines

Reseller/

DistlistTest.php

8 lines

6 lines

Feature/

Backends/

30 lines

Controller/

79 lines

82 lines

Diff 8567

src/app/Backends/LDAP.php

Loading...

src/app/Domain.php

Loading...

src/app/Group.php

Loading...

src/app/GroupSetting.php

Loading...

src/app/Http/Controllers/API/V4/DomainsController.php

Loading...

src/app/Http/Controllers/API/V4/GroupsController.php

Loading...

src/app/Http/Controllers/API/V4/UsersController.php

Loading...

src/app/Observers/GroupSettingObserver.php

Loading...

src/app/Providers/AppServiceProvider.php

Loading...

src/app/Tenant.php

Loading...

src/app/Traits/GroupConfigTrait.php

Loading...

src/app/Traits/SettingsTrait.php

Loading...

src/app/User.php

Loading...

src/app/Wallet.php

Loading...

src/database/migrations/2021_11_05_100000_create_group_settings_table.php

Loading...

src/resources/lang/en/app.php

Loading...

src/resources/lang/en/ui.php

Loading...

src/resources/lang/en/validation.php

Loading...

src/resources/vue/Admin/Distlist.vue

Loading...

src/resources/vue/Admin/Domain.vue

Loading...

src/resources/vue/Distlist/Info.vue

Loading...

src/routes/api.php

Loading...

src/tests/Browser/Admin/DistlistTest.php

Loading...

src/tests/Browser/Components/ListInput.php

Loading...

src/tests/Browser/DistlistTest.php

Loading...

src/tests/Browser/Pages/Admin/Distlist.php

Loading...

src/tests/Browser/Pages/DistlistInfo.php

Loading...

src/tests/Browser/Reseller/DistlistTest.php

Loading...

src/tests/Browser/Reseller/WalletTest.php

Loading...

src/tests/Feature/Backends/LDAPTest.php

Loading...

src/tests/Feature/Controller/GroupsTest.php

Loading...

src/tests/Feature/GroupTest.php

Loading...