Page MenuHomekolab.org

Group: Sender policy
ClosedPublic

Authored by machniak on Nov 5 2021, 2:57 PM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKa5633ffad441: Group: Sender policy
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/group-smtp-sender-policy
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 37010
Build 14756: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Nov 5 2021, 2:57 PM
machniak created this revision.
machniak updated this revision to Diff 8567.Nov 8 2021, 9:38 AM
  • Display sender policy in admin/reseller UI

Looks good to me aside from the UI text which I think could be a bit clearer.

src/database/migrations/2021_11_05_100000_create_group_settings_table.php
24

This is a string in the user_settings table, I assume we need to store larger values here?

src/resources/lang/en/ui.php
62

Suggestion:

With this list you can specify who can send mail to the distribution list."
. " You can put a complete email address (jane@kolab.org), domain (kolab.org) or suffix (.org) that the sender email address is be compared to."
. " If the list is empty, mail from anyone is allowed.

machniak added inline comments.Nov 8 2021, 10:23 AM
src/database/migrations/2021_11_05_100000_create_group_settings_table.php
24

It was a string initially, but later on changed to text. So, this is consistent, the default 'string' column length is not enough, indeed.

src/resources/lang/en/ui.php
62

Thx, I'll change that.

mollekopf accepted this revision.Nov 8 2021, 10:52 AM
This revision is now accepted and ready to land.Nov 8 2021, 10:52 AM
machniak updated this revision to Diff 8573.Nov 8 2021, 11:06 AM
  • Small wording improvement
This revision was automatically updated to reflect the committed changes.