Page MenuHomePhorge
Differential D2960

Introduce EntitleableTrait for code deduplication
ClosedPublic
Actions

Authored by machniak on Oct 19 2021, 12:34 PM.
Tags
None
Referenced Files
F11816283: D2960.id8465.diff
Fri, Apr 19, 9:36 PM
Unknown Object (File)
Thu, Apr 18, 10:17 AM
Unknown Object (File)
Wed, Apr 10, 8:18 AM
Unknown Object (File)
Sun, Apr 7, 10:02 PM
Unknown Object (File)
Sat, Apr 6, 11:18 PM
Unknown Object (File)
Sat, Apr 6, 9:47 AM
Unknown Object (File)
Fri, Mar 29, 10:13 AM
Unknown Object (File)
Mar 2 2024, 11:43 PM
View All 48 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK05652e38dcda: Introduce EntitleableTrait for code deduplication
Summary
  1. Code de-duplication
  2. Removed confusing entitlement() method
  3. Small performance improvement
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/perf-fix
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36872
Build 14672: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Oct 19 2021, 12:34 PM
machniak created this revision.
Harbormaster completed remote builds in B36872: Diff 8459.Oct 19 2021, 12:34 PM
machniak updated this revision to Diff 8465.Oct 19 2021, 12:53 PM
  • Re-order "use" clauses
Harbormaster completed remote builds in B36878: Diff 8465.Oct 19 2021, 12:53 PM
mollekopf accepted this revision.Oct 25 2021, 11:52 AM
mollekopf subscribed.

Looks good.

This revision is now accepted and ready to land.Oct 25 2021, 11:52 AM
Closed by commit rK05652e38dcda: Introduce EntitleableTrait for code deduplication (authored by machniak). · Explain WhyOct 25 2021, 12:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
Domain/
4 lines
40 lines
29 lines
Traits/
39 lines
46 lines
tests/
Feature/
Console/
Domain/
8 lines
2 lines
Controller/
2 lines
2 lines

Diff 8459

View Options

src/app/Console/Commands/Domain/SetWalletCommand.php

Loading...
View Options

src/app/Domain.php

Loading...
View Options

src/app/Group.php

Loading...
View Options

src/app/Traits/EntitleableTrait.php

Loading...
View Options

src/app/User.php

Loading...
View Options

src/tests/Feature/Console/Domain/SetWalletTest.php

Loading...
View Options

src/tests/Feature/Console/OwnerSwapTest.php

Loading...
View Options

src/tests/Feature/Controller/DomainsTest.php

Loading...
View Options

src/tests/Feature/GroupTest.php

Loading...