Introduce EntitleableTrait for code deduplication
ClosedPublic
Actions

Authored by machniak on Oct 19 2021, 12:34 PM.

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

Summary

Test Plan

./phpunit

Repository

rK kolab

Branch

dev/perf-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 36878
Build 14678: arc lint + arc unit

machniak requested review of this revision.Oct 19 2021, 12:34 PM

machniak created this revision.

Looks good.

This revision is now accepted and ready to land.Oct 25 2021, 11:52 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/app/Console/Commands/Domain/SetWalletCommand.php (4 lines)
M		src/app/Domain.php (40 lines)
M		src/app/Group.php (29 lines)
A	M	src/app/Traits/EntitleableTrait.php (39 lines)
M		src/app/User.php (52 lines)
M		src/tests/Feature/Console/Domain/SetWalletTest.php (8 lines)
M		src/tests/Feature/Console/OwnerSwapTest.php (2 lines)
M		src/tests/Feature/Controller/DomainsTest.php (2 lines)
M		src/tests/Feature/GroupTest.php (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8459	8396cd3		Oct 19 2021, 12:33 PM	★	★
Diff 2	8465	8396cd3	- Re-order "use" clauses	Oct 19 2021, 12:53 PM	★	★
Diff 3	8501	8396cd3	rK05652e38dcda809832fec919ae6fe8a0ea05940b	Oct 25 2021, 12:03 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7d34a22be476	736918184d70	c81837520b3f	Aleksander Machniak	Re-order "use" clauses	Oct 19 2021, 12:52 PM
c81837520b3f	9c1ee67f4ac7	7612cdb9d551	Aleksander Machniak	Introduce EntitleableTrait for code deduplication (Show More…)	Oct 19 2021, 12:29 PM
7612cdb9d551	d04d5043524e	8396cd3faa6b	Aleksander Machniak	Small performance improvement	Oct 19 2021, 11:38 AM