Page MenuHomePhorge
Differential D2918

Add artisan owner:swap command
ClosedPublic
Actions

Authored by machniak on Oct 1 2021, 4:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 11, 3:13 AM
Unknown Object (File)
Mon, Jun 10, 8:43 PM
Unknown Object (File)
Mon, May 27, 7:45 PM
Unknown Object (File)
Mon, May 27, 5:37 AM
Unknown Object (File)
Tue, May 21, 7:27 PM
Unknown Object (File)
May 5 2024, 5:02 AM
Unknown Object (File)
May 3 2024, 5:56 AM
Unknown Object (File)
May 1 2024, 7:11 AM
View All 51 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK86ea94306654: Add artisan owner:swap command
Test Plan

./phpunit tests/Feature/Console/OwnerSwapTest.php

Diff Detail

Repository
rK kolab
Branch
dev/owner-swap
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36743
Build 14606: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Oct 1 2021, 4:13 PM
machniak created this revision.
Harbormaster completed remote builds in B36740: Diff 8348.Oct 1 2021, 4:13 PM
machniak updated this revision to Diff 8354.Oct 1 2021, 4:18 PM
  • Add todo comment
Harbormaster completed remote builds in B36743: Diff 8354.Oct 1 2021, 4:18 PM
machniak updated this revision to Diff 8360.Oct 4 2021, 9:01 AM
  • Update mollie customer email/name on owner swap
Harbormaster completed remote builds in B36749: Diff 8360.Oct 4 2021, 9:01 AM
mollekopf accepted this revision.Oct 6 2021, 9:51 AM
mollekopf subscribed.

Looks good.

Notes (no blockers I think):

  • The wallet description is not copied
  • It's not clear to me why the targetWallet needs to be one month old, perhaps add a comment.
  • The "same account" check is a bit obscure and would deserve a dedicated method I think: User::controlledBySameWallet($users)
This revision is now accepted and ready to land.Oct 6 2021, 9:51 AM
Closed by commit rK86ea94306654: Add artisan owner:swap command (authored by machniak). · Explain WhyOct 6 2021, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
95 lines
tests/
Feature/
Console/
99 lines

Diff 8354

View Options

src/app/Console/Commands/OwnerSwapCommand.php

Loading...
View Options

src/tests/Feature/Console/OwnerSwapTest.php

Loading...