Page MenuHomePhorge

Add artisan owner:swap command
ClosedPublic

Authored by machniak on Oct 1 2021, 4:13 PM.
Tags
None
Referenced Files
F11583903: D2918.diff
Thu, Mar 28, 6:00 AM
Unknown Object (File)
Feb 24 2024, 5:20 PM
Unknown Object (File)
Feb 14 2024, 6:34 PM
Unknown Object (File)
Feb 11 2024, 9:03 AM
Unknown Object (File)
Jan 31 2024, 2:34 PM
Unknown Object (File)
Jan 30 2024, 1:43 AM
Unknown Object (File)
Jan 27 2024, 7:38 AM
Unknown Object (File)
Jan 24 2024, 2:17 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK86ea94306654: Add artisan owner:swap command
Test Plan

./phpunit tests/Feature/Console/OwnerSwapTest.php

Diff Detail

Repository
rK kolab
Branch
dev/owner-swap
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36749
Build 14612: arc lint + arc unit

Event Timeline

machniak created this revision.
  • Update mollie customer email/name on owner swap
mollekopf subscribed.

Looks good.

Notes (no blockers I think):

  • The wallet description is not copied
  • It's not clear to me why the targetWallet needs to be one month old, perhaps add a comment.
  • The "same account" check is a bit obscure and would deserve a dedicated method I think: User::controlledBySameWallet($users)
This revision is now accepted and ready to land.Oct 6 2021, 9:51 AM
This revision was automatically updated to reflect the committed changes.