Differential D2395

Localization with vue-i18n
ClosedPublic
Actions

Authored by machniak on Mar 22 2021, 12:59 PM.

Project Tags

None

Referenced Files

	F121506338: D2395.1777469643.diff
	Tue, Apr 28, 1:34 PM

	F121477375: D2395.1777444710.diff
	Tue, Apr 28, 6:38 AM

	F121447032: D2395.1777420099.diff
	Mon, Apr 27, 11:48 PM

	F121428572: D2395.1777401579.diff
	Mon, Apr 27, 6:39 PM

	F121404442: D2395.1777378460.diff
	Mon, Apr 27, 12:14 PM

	F121401299: D2395.1777375647.diff
	Mon, Apr 27, 11:27 AM

	F121351802: D2395.1777339404.diff
	Mon, Apr 27, 1:23 AM

	F121298053: D2395.1777287777.diff
	Sun, Apr 26, 11:02 AM

View All 67 Files

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK18a7cd7dbd77: Localization with vue-i18n

Summary

vue-i18n is the most robust and most used solution. It adds ~30KB to the minified js file size. Quite a lot, but all other solutions I saw look very weak in comparison to vue-i18n.

UI (vue) localization engine
Theme files localization engine
Language selector in UI
Passing selected language to API calls, and setting the laravel locale accordingly
Browser (preferred) language auto-detection
Localization of theme-specific menu and faq items

Diff Detail

Repository

Branch

dev/localization

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 33928
Build 13468: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Mar 22 2021, 12:59 PM

machniak created this revision.

Harbormaster completed remote builds in B33661: Diff 6676.Mar 22 2021, 12:59 PM

Upgrade to laravel-mix v6 (webpack v5) and other js dependencies
Don't preload English

Harbormaster completed remote builds in B33709: Diff 6727.Mar 23 2021, 1:24 PM

machniak edited the summary of this revision. (Show Details)Mar 23 2021, 1:26 PM

Localization engine for theme files

Harbormaster completed remote builds in B33715: Diff 6733.Mar 23 2021, 2:40 PM

machniak edited the summary of this revision. (Show Details)Mar 23 2021, 2:43 PM

machniak edited the summary of this revision. (Show Details)Mar 23 2021, 2:46 PM

Upgrade to laravel-mix v6 (webpack v5) and other js dependencies
Don't preload English
Localization engine for theme files
Rebase
Improve language selector

Harbormaster completed remote builds in B33922: Diff 6889.Apr 15 2021, 1:28 PM

Hide the lang selector if there's only a single language available

Harbormaster completed remote builds in B33928: Diff 6895.Apr 16 2021, 7:27 AM

Manu localization
FAQ localization

Harbormaster completed remote builds in B33934: Diff 6901.Apr 16 2021, 11:06 AM

machniak edited the summary of this revision. (Show Details)Apr 16 2021, 11:17 AM

Rebase
Improve language selector
Store UI localization in php file
Remove unused Laravel localization files

Harbormaster completed remote builds in B34015: Diff 6973.Apr 23 2021, 12:46 PM

Store user language in a cookie, always load English
Small code cleanup
Update tests
Small linting fixes
Browser test for the language selector

Harbormaster completed remote builds in B34027: Diff 6979.Apr 26 2021, 12:22 PM

Small css improvements to the page menu

Harbormaster completed remote builds in B34033: Diff 6985.Apr 26 2021, 1:13 PM

machniak retitled this revision from [WIP] Localization with vue-i18n to Localization with vue-i18n.Apr 27 2021, 7:41 AM

machniak edited the summary of this revision. (Show Details)

mollekopf accepted this revision.May 6 2021, 1:44 PM

This revision is now accepted and ready to land.May 6 2021, 1:44 PM

Closed by commit rK18a7cd7dbd77: Localization with vue-i18n. · Explain WhyMay 7 2021, 10:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lines

app/

Http/

Controllers/

ContentController.php

lines

line

Middleware/

lines

lines

config/

lines

package-lock.json

lines

line

resources/

js/

lines

lines

lang/

de/

lines

en/

lines

themes/

default/

lang/

de/

lines

en/

lines

pages/

support.blade.php

lines

lines

vue/

lines

Widgets/

lines

Diff 6895

src/.env.example

Loading...

src/app/Http/Controllers/ContentController.php

Loading...

src/app/Http/Kernel.php

Loading...

src/app/Http/Middleware/Locale.php

Loading...

src/app/Utils.php

Loading...

src/config/app.php

Loading...

src/package-lock.json

Loading...

src/package.json

Loading...

src/resources/js/app.js

Loading...

src/resources/js/locale.js

Loading...

src/resources/lang/de/ui.json

Loading...

src/resources/lang/en/ui.json

Loading...

src/resources/themes/default/lang/de/support.php

Loading...

src/resources/themes/default/lang/en/support.php

Loading...

src/resources/themes/default/pages/support.blade.php

Loading...

src/resources/themes/menu.scss

Loading...

src/resources/vue/Login.vue

Loading...

src/resources/vue/Widgets/Menu.vue

Loading...