Page MenuHomePhorge
Differential D2197

Improve handling of screen-sharing connection tokens
ClosedPublic
Actions

Authored by machniak on Feb 1 2021, 11:20 AM.
Tags
None
Referenced Files
F12877098: D2197.id6157.diff
Sun, Jun 16, 7:28 PM
F12866919: D2197.id6151.diff
Sun, Jun 16, 4:50 AM
F12864948: D2197.id6121.diff
Sun, Jun 16, 1:47 AM
Unknown Object (File)
Fri, Jun 14, 8:13 AM
Unknown Object (File)
Thu, Jun 13, 3:29 PM
Unknown Object (File)
Thu, Jun 6, 4:18 AM
Unknown Object (File)
Fri, May 24, 10:21 PM
Unknown Object (File)
Fri, May 24, 12:16 PM
View All 54 Files
Subscribers
vanmeeuwen
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK25a7d2fbb9df: Improve handling of screen-sharing connection tokens
rK214ea4ead699: Merge branch 'dev/D2149' into arcpatch-D2197
rKae8c0d6f25fc: Improve handling of screen-sharing connection tokens
rKe4bb4f88f6e1: Fix type hint
rKe968a6ccf02d: Improve handling of screen-sharing connection tokens
rK8ca91d53f4fc: Fix connection role propagation to new connections
rKd80c6c0ebeeb: Add tests for media setup dialog
rK610cf13921c4: Fix test regressions
rK4088e8d694b6: Media setup dialog
rK918f5bfcbc2f: Test updateConnection endpoint
rKbab58fac8f70: More tests
rK6eb144d54850: Simplify resize() calls
rK9b82d3a28500: Cleanup
rK06226e33da8b: Tests: Use the menu when changing nickname
rK1c61c1e36f17: Fix regressions
rKb7baff245328: Use proper event system to handle audio/video status indication Add "Nickname"…
rKd0bfc17e4ba5: Improve menu layout
rKff81deb8fecd: Publisher-to-subscriber and vice-versa
Summary

Also fixes issues when dismissing a screen-sharing connection.

Requires D2191

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
arcpatch-D2197
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 33046
Build 12889: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Feb 1 2021, 11:20 AM
machniak created this revision.
Harbormaster completed remote builds in B33022: Diff 6121.Feb 1 2021, 11:21 AM
machniak updated this revision to Diff 6127.Feb 1 2021, 11:32 AM
  • Fix type hint
Harbormaster completed remote builds in B33028: Diff 6127.Feb 1 2021, 11:32 AM
vanmeeuwen added a child revision: D2191: OpenVidu: Moderators.Feb 1 2021, 11:40 AM
vanmeeuwen removed a child revision: D2191: OpenVidu: Moderators.
vanmeeuwen added a parent revision: D2191: OpenVidu: Moderators.
vanmeeuwen updated this revision to Diff 6139.Feb 1 2021, 12:11 PM
vanmeeuwen subscribed.
  • Merge branch 'dev/D2149' into arcpatch-D2197
Harbormaster completed remote builds in B33040: Diff 6139.Feb 1 2021, 12:11 PM
vanmeeuwen updated this revision to Diff 6145.Feb 1 2021, 12:15 PM

Against dev/D2191 please

Harbormaster completed remote builds in B33046: Diff 6145.Feb 1 2021, 12:15 PM
vanmeeuwen updated this revision to Diff 6151.Feb 1 2021, 12:22 PM

Try again to remove duplicate changes

Harbormaster completed remote builds in B33052: Diff 6151.Feb 1 2021, 12:22 PM
vanmeeuwen updated this revision to Diff 6157.Feb 2 2021, 11:38 AM

Fresh merge of dev/screen-sharing-tokens on top of dev/D2191

  • Fix type hint
  • Merge branch 'dev/D2191' into dev/screen-sharing-tokens
Harbormaster completed remote builds in B33058: Diff 6157.Feb 2 2021, 11:38 AM
vanmeeuwen accepted this revision.Feb 2 2021, 11:43 AM
This revision is now accepted and ready to land.Feb 2 2021, 11:43 AM
Closed by commit rK25a7d2fbb9df: Improve handling of screen-sharing connection tokens (authored by vanmeeuwen). · Explain WhyFeb 2 2021, 11:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
87 lines
OpenVidu/
5 lines
resources/
js/
meet/
126 lines
themes/
4 lines
vue/
Meet/
46 lines
routes/
7 lines
tests/
Browser/
Meet/
1 line
185 lines
6 lines
Feature/
Controller/
148 lines

Diff 6145

View Options

src/app/Http/Controllers/API/V4/OpenViduController.php

Loading...
View Options

src/app/OpenVidu/Room.php

Loading...
View Options

src/resources/js/meet/app.js

Loading...
View Options

src/resources/themes/app.scss

Loading...
View Options

src/resources/vue/Meet/Room.vue

Loading...
View Options

src/routes/api.php

Loading...
View Options

src/tests/Browser/Meet/RoomControlsTest.php

Loading...
View Options

src/tests/Browser/Meet/RoomModeratorTest.php

Loading...
View Options

src/tests/Browser/Meet/RoomSetupTest.php

Loading...
View Options

src/tests/Feature/Controller/OpenViduTest.php

Loading...