Page MenuHomePhorge
Differential D1714

Beta SKUs
ClosedPublic
Actions

Authored by machniak on Oct 7 2020, 10:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 25, 6:51 AM
Unknown Object (File)
Fri, May 24, 5:34 AM
Unknown Object (File)
Apr 27 2024, 7:04 AM
Unknown Object (File)
Apr 26 2024, 7:33 PM
Unknown Object (File)
Apr 20 2024, 3:10 AM
Unknown Object (File)
Apr 19 2024, 5:39 AM
Unknown Object (File)
Mar 29 2024, 12:43 AM
Unknown Object (File)
Mar 22 2024, 3:11 AM
View All 31 Files
Subscribers
vanmeeuwen
Restricted Project

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK3beb78979551: Beta SKUs
rK117e3e804bce: Beta SKUs
Summary
  • Added "meet" and "beta" SKUs
  • Added sku:list-users and user:assign-sku commands
  • Unification in SKU handlers
  • More tests
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/beta
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31183
Build 11737: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Oct 7 2020, 10:51 AM
machniak created this revision.
Harbormaster completed remote builds in B31183: Diff 4588.Oct 7 2020, 10:51 AM
vanmeeuwen subscribed.Oct 7 2020, 11:37 AM

I've skimmed the surface, haven't fully reviewed this yet.

src/app/Handlers/Base.php
57

the value for the boolean and the comment seem to contradict one another.

machniak updated this revision to Diff 4924.Oct 23 2020, 10:57 AM
  • Rephrase comments
Harbormaster completed remote builds in B31513: Diff 4924.Oct 23 2020, 10:57 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 4 2020, 1:35 PM
Closed by commit rK3beb78979551: Beta SKUs (authored by machniak, committed by vanmeeuwen). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
Sku/
64 lines
60 lines
Handlers/
29 lines
29 lines
62 lines
Beta.php
Base.php
14 lines
Beta/
73 lines
18 lines
15 lines
15 lines
15 lines
15 lines
15 lines
41 lines
15 lines
15 lines
29 lines
Http/
Controllers/
API/
V4/
102 lines
Observers/
16 lines
6 lines
database/
seeds/
local/
26 lines
production/
26 lines
resources/
vue/
Admin/
4 lines
User/
3 lines
routes/
2 lines
tests/
Browser/
70 lines
Feature/
Console/
Sku/
78 lines
63 lines
Controller/
163 lines
2 lines
2 lines
2 lines
2 lines

Diff 4588

View Options

src/app/Console/Commands/Sku/ListUsers.php

Loading...
View Options

src/app/Console/Commands/UserAssignSku.php

Loading...
View Options

src/app/Handlers/Activesync.php

Loading...
View Options

src/app/Handlers/Auth2F.php

Loading...
View Options

src/app/Handlers/Base.php

Loading...
View Options

src/app/Handlers/Beta.php

Loading...
View Options

src/app/Handlers/Beta/Base.php

Loading...
View Options

src/app/Handlers/Beta/Meet.php

Loading...
View Options

src/app/Handlers/Domain.php

Loading...
View Options

src/app/Handlers/DomainHosting.php

Loading...
View Options

src/app/Handlers/DomainRegistration.php

Loading...
View Options

src/app/Handlers/DomainRelay.php

Loading...
View Options

src/app/Handlers/Groupware.php

Loading...
View Options

src/app/Handlers/Mailbox.php

Loading...
View Options

src/app/Handlers/Resource.php

Loading...
View Options

src/app/Handlers/SharedFolder.php

Loading...
View Options

src/app/Handlers/Storage.php

Loading...
View Options

src/app/Http/Controllers/API/V4/SkusController.php

Loading...
View Options

src/app/Observers/EntitlementObserver.php

Loading...
View Options

src/app/User.php

Loading...
View Options

src/database/seeds/local/SkuSeeder.php

Loading...
View Options

src/database/seeds/production/SkuSeeder.php

Loading...
View Options

src/resources/vue/Admin/User.vue

Loading...
View Options

src/resources/vue/User/Info.vue

Loading...
View Options

src/routes/api.php

Loading...
View Options

src/tests/Browser/UsersTest.php

Loading...
View Options

src/tests/Feature/Console/Sku/ListUsersTest.php

Loading...
View Options

src/tests/Feature/Console/UserAssignSkuTest.php

Loading...
View Options

src/tests/Feature/Controller/SkusTest.php

Loading...
View Options

src/tests/Feature/DomainTest.php

Loading...
View Options

src/tests/Feature/SignupCodeTest.php

Loading...
View Options

src/tests/Feature/VerificationCodeTest.php

Loading...
View Options

src/tests/Feature/WalletTest.php

Loading...