Differential D208

T1414: Set LDAP TIMEOUT option only on "immediate" connection
ClosedPublic
Actions

Authored by machniak on Aug 18 2016, 2:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 16, 6:21 PM

	Unknown Object (File)
	Sun, Apr 14, 10:14 PM

	Unknown Object (File)
	Mon, Apr 8, 6:17 AM

	Unknown Object (File)
	Sat, Apr 6, 2:10 PM

	Unknown Object (File)
	Wed, Apr 3, 1:02 PM

	Unknown Object (File)
	Wed, Apr 3, 1:02 PM

	Unknown Object (File)
	Wed, Apr 3, 1:02 PM

	Unknown Object (File)
	Wed, Apr 3, 1:02 PM

Subscribers

Details

Reviewers

Group Reviewers

PyKolab Developers

Maniphest Tasks

T1414: Kolabd not catching changes in LDAP

Commits

rP764103053f06: T1414: Set LDAP TIMEOUT option only on "immediate" connection
rP54cb493d655b: T1414: Set LDAP TIMEOUT option only on "immediate" connection

Summary

Fixes T1414.

Shouldn't we handle ldap.TIMEOUT exception in authenticate()?

Diff Detail

Repository

Branch

dev/T1414

Lint

Lint Errors

Severity	Location	Code	Message
Error	pykolab/auth/ldap/__init__.py:1022	E266	PEP8 E266
Error	pykolab/auth/ldap/__init__.py:1396	E266	PEP8 E266
Error	pykolab/auth/ldap/__init__.py:2694	E266	PEP8 E266

Unit

No Test Coverage

Build Status

Buildable 4457
Build 4458: arc lint + arc unit

Event Timeline

machniak updated this revision to Diff 455.Aug 18 2016, 2:18 PM

machniak retitled this revision from to T1414: Set LDAP TIMEOUT option only on "immediate" connection.

machniak updated this object.

machniak edited the test plan for this revision. (Show Details)

machniak added a reviewer: PyKolab Developers.

machniak added a task: T1414: Kolabd not catching changes in LDAP.

Fixed default for immediate argument of connect()

This fix works but is yet not integrated in Winterfell. On every update I have to Change it manually...

I have added the patch to Winterfell now.

vanmeeuwen accepted this revision.Oct 6 2016, 9:37 AM

vanmeeuwen added a reviewer: vanmeeuwen.

This revision is now accepted and ready to land.Oct 6 2016, 9:37 AM

Closed by commit rP54cb493d655b: T1414: Set LDAP TIMEOUT option only on "immediate" connection (authored by machniak, committed by vanmeeuwen). · Explain WhyOct 6 2016, 11:38 AM

This revision was automatically updated to reflect the committed changes.

vendel.colja mentioned this in T1307: make pykolab synchronize queueing mechanism reliable.Oct 11 2016, 1:45 PM

Revision Contents
Changeset List

Path

Size

pykolab/

auth/

ldap/

3 lines

Diff 455

pykolab/auth/ldap/init.py

Loading...