Page MenuHomePhorge
Differential D182

Eliminate get_entry_attribute() in setup_ldap
ClosedPublic
Actions

Authored by machniak on Jun 16 2016, 11:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 4:18 PM
Unknown Object (File)
Tue, Apr 30, 4:29 PM
Unknown Object (File)
Mon, Apr 29, 5:47 PM
Unknown Object (File)
Sun, Apr 28, 7:08 PM
Unknown Object (File)
Fri, Apr 26, 11:51 AM
Unknown Object (File)
Fri, Apr 12, 9:11 PM
Unknown Object (File)
Mar 31 2024, 2:48 PM
Unknown Object (File)
Mar 17 2024, 6:03 PM
View All Files
Subscribers
None

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rP571d9a0aaf4c: Eliminate get_entry_attribute() in setup_ldap
rPbb792438366b: Eliminate get_entry_attribute() in setup_ldap
Summary

This is redundant and can cause useless ldap re-connection.
Small CS fixes

Warning: This wasn't tested.

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 397.Jun 16 2016, 11:36 AM
machniak retitled this revision from to Eliminate get_entry_attribute() in setup_ldap.
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen accepted this revision.Jun 29 2016, 3:56 PM
vanmeeuwen added a reviewer: vanmeeuwen.
This revision is now accepted and ready to land.Jun 29 2016, 3:56 PM
Closed by commit rPbb792438366b: Eliminate get_entry_attribute() in setup_ldap (authored by machniak, committed by vanmeeuwen). · Explain WhyJun 29 2016, 3:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
setup/
20 lines

Diff 422

View Options

pykolab/setup/setup_ldap.py

Loading...