Page MenuHomePhorge
Differential D182

Eliminate get_entry_attribute() in setup_ldap
ClosedPublic
Actions

Authored by machniak on Jun 16 2016, 11:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 9:11 PM
Unknown Object (File)
Sun, Mar 31, 2:48 PM
Unknown Object (File)
Mar 17 2024, 6:03 PM
Unknown Object (File)
Mar 9 2024, 9:39 PM
Unknown Object (File)
Mar 7 2024, 8:48 AM
Unknown Object (File)
Feb 13 2024, 10:47 AM
Unknown Object (File)
Feb 9 2024, 11:28 PM
Unknown Object (File)
Jan 29 2024, 5:46 PM
View All Files
Subscribers
None

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rP571d9a0aaf4c: Eliminate get_entry_attribute() in setup_ldap
rPbb792438366b: Eliminate get_entry_attribute() in setup_ldap
Summary

This is redundant and can cause useless ldap re-connection.
Small CS fixes

Warning: This wasn't tested.

Diff Detail

Repository
rP pykolab
Branch
dev/setup_ldap_improvement
Lint
Lint Errors
SeverityLocationCodeMessage
Errorpykolab/setup/setup_ldap.py:49E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:50E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:52E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:57E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:58E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:60E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:65E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:66E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:68E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:73E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:74E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:76E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:81E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:82E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:84E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:89E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:90E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:92E221PEP8 E221
Errorpykolab/setup/setup_ldap.py:329E265PEP8 E265
Errorpykolab/setup/setup_ldap.py:330E265PEP8 E265
Errorpykolab/setup/setup_ldap.py:438E502PEP8 E502
Errorpykolab/setup/setup_ldap.py:439E128PEP8 E128
Errorpykolab/setup/setup_ldap.py:685E502PEP8 E502
Errorpykolab/setup/setup_ldap.py:686E128PEP8 E128
Unit
No Test Coverage
Build Status
Buildable 3974
Build 3960: arc lint + arc unit

Event Timeline

machniak updated this revision to Diff 397.Jun 16 2016, 11:36 AM
machniak retitled this revision from to Eliminate get_entry_attribute() in setup_ldap.
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen accepted this revision.Jun 29 2016, 3:56 PM
vanmeeuwen added a reviewer: vanmeeuwen.
This revision is now accepted and ready to land.Jun 29 2016, 3:56 PM
Closed by commit rPbb792438366b: Eliminate get_entry_attribute() in setup_ldap (authored by machniak, committed by vanmeeuwen). · Explain WhyJun 29 2016, 3:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
setup/
20 lines

Diff 397

View Options

pykolab/setup/setup_ldap.py

Loading...