fix crash in capabilities response handling, and don't touch the response here
ClosedPublic
Actions

Authored by • seigo on Jun 20 2016, 4:58 PM.

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rEIbaf515e9c426: Merge branch 'master' into develop
rEI8fc55d37e444: Merge branch 'feature/passthrough_capabilities_untouched' of ssh://git.kolab.
rEIa7511ce1de44: fix crash in capabilities response handling, and don't touch the response here

Summary

the explicit capabilities command is multiline, so it produces a list response,
and eimap should not touch the incoming response, but leave that to the application.

Diff Detail

Repository

rEI eimap

Branch

feature/passthrough_capabilities_untouched

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4021
Build 4008: arc lint + arc unit

Event Timeline

• seigo updated this revision to Diff 410.Jun 20 2016, 4:58 PM

• seigo retitled this revision from to fix crash in capabilities response handling, and don't touch the response here.

• seigo updated this object.

• seigo edited the test plan for this revision. (Show Details)

• seigo added a reviewer: Restricted Project.

This fixes the crash just fine.

It doesn't resolve the remaining or resulting problems though, of missing STARTTLS in the capabilities needing to be exposed to the client, especially since the chunk of code here seems to be interested more in posttls_capabilities (which shouldn't have STARTTLS to begin with?), whereas what I suppose we also need to fix is handling pretls_capabilities.