Page MenuHomePhorge

fix crash in capabilities response handling, and don't touch the response here
ClosedPublic

Authored by seigo on Jun 20 2016, 4:58 PM.
Tags
None
Referenced Files
F11588070: D187.diff
Thu, Mar 28, 7:16 PM
F11585178: D187.diff
Thu, Mar 28, 10:55 AM
Unknown Object (File)
Sun, Mar 24, 5:10 PM
Unknown Object (File)
Tue, Mar 5, 3:02 PM
Unknown Object (File)
Tue, Mar 5, 3:02 PM
Unknown Object (File)
Sat, Mar 2, 4:59 AM
Unknown Object (File)
Sat, Mar 2, 4:51 AM
Unknown Object (File)
Feb 26 2024, 3:59 AM
Subscribers

Details

Summary

the explicit capabilities command is multiline, so it produces a list response,
and eimap should not touch the incoming response, but leave that to the application.

Diff Detail

Repository
rEI eimap
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

seigo retitled this revision from to fix crash in capabilities response handling, and don't touch the response here.
seigo updated this object.
seigo edited the test plan for this revision. (Show Details)
seigo added a reviewer: Restricted Project.

This fixes the crash just fine.

It doesn't resolve the remaining or resulting problems though, of missing STARTTLS in the capabilities needing to be exposed to the client, especially since the chunk of code here seems to be interested more in posttls_capabilities (which shouldn't have STARTTLS to begin with?), whereas what I suppose we also need to fix is handling pretls_capabilities.

This revision was automatically updated to reflect the committed changes.