Fix bug in getmetadata command: new_command/4 was allowing Folder to be a list, when the internal API required it to be binary
ClosedPublic
Actions

Authored by • seigo on Jun 6 2016, 4:20 PM.

Details

Reviewers

vanmeeuwen
mollekopf

Group Reviewers

Restricted Project

Commits

rEIc552baaa073b: the arity-4 version also needs to check for Folder being a list
rEIa74700b97a85: Merge branch 'feature/fix_getmetadata' into develop
rEIba140108083c: Fix bug in getmetadata command: new_command/4 was allowing Folder to be a…
rEIa8cea22c48ad: explain why we have a 4-tuple version of new_command
rEIa7aed1170835: comand -> command

Summary

the arity-4 version also needs to check for Folder being a list

this is now dead code, as new_command/4 handles the check for list now

Diff Detail

Repository

rEI eimap

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• seigo updated this revision to Diff 374.Jun 6 2016, 4:20 PM

• seigo retitled this revision from to Fix bug in getmetadata command: new_command/4 was allowing Folder to be a list, when the internal API required it to be binary.

• seigo updated this object.

• seigo edited the test plan for this revision. (Show Details)

• seigo added a reviewer: Restricted Project.

mollekopf accepted this revision.Jun 6 2016, 4:26 PM

mollekopf added a reviewer: mollekopf.

This revision is now accepted and ready to land.Jun 6 2016, 4:26 PM

vanmeeuwen subscribed.Jun 6 2016, 4:33 PM

vanmeeuwen added inline comments.

src/commands/eimap_command_getmetadata.erl
29	Please copy/paste, omit MaxSize as a parameter, yet be all kitty-like and land on 3-4 feet. Or, ... insert a comment about handling this yay way rather than other way in comparison with, for example, Cyrus IMAP.