Page MenuHomekolab.org

Fix bug in getmetadata command: new_command/4 was allowing Folder to be a list, when the internal API required it to be binary
ClosedPublic

Authored by seigo on Jun 6 2016, 4:20 PM.

Diff Detail

Repository
rEI eimap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seigo updated this revision to Diff 374.Jun 6 2016, 4:20 PM
seigo retitled this revision from to Fix bug in getmetadata command: new_command/4 was allowing Folder to be a list, when the internal API required it to be binary.
seigo updated this object.
seigo edited the test plan for this revision. (Show Details)
seigo added a reviewer: Restricted Project.
mollekopf accepted this revision.Jun 6 2016, 4:26 PM
mollekopf added a reviewer: mollekopf.
This revision is now accepted and ready to land.Jun 6 2016, 4:26 PM
vanmeeuwen added inline comments.
src/commands/eimap_command_getmetadata.erl
29

Please copy/paste, omit MaxSize as a parameter, yet be all kitty-like and land on 3-4 feet.

Or, ...

insert a comment about handling this yay way rather than other way in comparison with, for example, Cyrus IMAP.

vanmeeuwen requested changes to this revision.Jun 6 2016, 4:33 PM
vanmeeuwen added a reviewer: vanmeeuwen.
This revision now requires changes to proceed.Jun 6 2016, 4:33 PM
seigo updated this revision to Diff 375.Jun 6 2016, 4:35 PM
seigo edited edge metadata.
  • explain why we have a 4-tuple version of new_command

Updating D170: Fix bug in getmetadata command: new_command/4 was allowing Folder

to be a list, when the internal API required it to be binary

vanmeeuwen accepted this revision.Jun 6 2016, 4:36 PM
vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 4:36 PM
vanmeeuwen requested changes to this revision.Jun 6 2016, 4:38 PM
vanmeeuwen edited edge metadata.
This revision now requires changes to proceed.Jun 6 2016, 4:38 PM
vanmeeuwen accepted this revision.Jun 6 2016, 4:38 PM
vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 4:38 PM
This revision was automatically updated to reflect the committed changes.