Page MenuHomePhorge
Differential D136

Trim spaces in surname/givenname/sn when generating mail/alias (#5360)
ClosedPublic
Actions

Authored by machniak on Apr 18 2016, 5:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 2:47 AM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Thu, Apr 11, 12:00 AM
Unknown Object (File)
Wed, Apr 10, 11:56 PM
Unknown Object (File)
Wed, Apr 10, 11:46 PM
Unknown Object (File)
Mar 12 2024, 2:02 PM
View All Files
Subscribers
vanmeeuwen

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rP284dab73ba7b: Trim spaces in surname/givenname/sn when generating mail/alias (#5360)
rP3e419b753a28: Trim spaces in surname/givenname/sn when generating mail/alias (#5360)

Diff Detail

Repository
rP pykolab
Branch
dev/5360
Lint
Lint Errors
SeverityLocationCodeMessage
Errorpykolab/utils.py:35E302PEP8 E302
Errorpykolab/utils.py:44E501PEP8 E501
Errorpykolab/utils.py:47E501PEP8 E501
Errorpykolab/utils.py:47E711PEP8 E711
Errorpykolab/utils.py:53E711PEP8 E711
Errorpykolab/utils.py:58E711PEP8 E711
Errorpykolab/utils.py:69E501PEP8 E501
Errorpykolab/utils.py:74E502PEP8 E502
Errorpykolab/utils.py:75E128PEP8 E128
Errorpykolab/utils.py:78E711PEP8 E711
Errorpykolab/utils.py:81E501PEP8 E501
Errorpykolab/utils.py:83E711PEP8 E711
Errorpykolab/utils.py:86E501PEP8 E501
Errorpykolab/utils.py:96E302PEP8 E302
Errorpykolab/utils.py:104E201PEP8 E201
Errorpykolab/utils.py:104E202PEP8 E202
Errorpykolab/utils.py:108E201PEP8 E201
Errorpykolab/utils.py:108E202PEP8 E202
Errorpykolab/utils.py:118E501PEP8 E501
Errorpykolab/utils.py:120E231PEP8 E231
Errorpykolab/utils.py:120E231PEP8 E231
Errorpykolab/utils.py:127E712PEP8 E712
Errorpykolab/utils.py:128E231PEP8 E231
Errorpykolab/utils.py:128E231PEP8 E231
Errorpykolab/utils.py:131E711PEP8 E711
Unit
No Test Coverage
Build Status
Buildable 3569
Build 3544: arc lint + arc unit

Event Timeline

machniak updated this revision to Diff 286.Apr 18 2016, 5:35 PM
machniak retitled this revision from to Trim spaces in surname/givenname/sn when generating mail/alias (#5360).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen requested changes to this revision.May 4 2016, 3:56 PM
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen subscribed.

This may be better suited for utils.normalize(), which already iterates over keys and values.

This revision now requires changes to proceed.May 4 2016, 3:56 PM
machniak updated this revision to Diff 331.May 5 2016, 1:38 PM
machniak edited edge metadata.

Moved the trimming code to utils.normalize(), added tests

machniak updated this revision to Diff 332.May 5 2016, 1:40 PM
machniak edited edge metadata.

Removed redundant import

vanmeeuwen accepted this revision.May 13 2016, 10:45 AM
vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 10:45 AM
Closed by commit rP3e419b753a28: Trim spaces in surname/givenname/sn when generating mail/alias (#5360) (authored by machniak, committed by vanmeeuwen). · Explain WhyMay 13 2016, 10:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
pykolab/
23 lines
tests/
unit/
19 lines
30 lines

Diff 331

View Options

.gitignore

Loading...
View Options

pykolab/utils.py

Loading...
View Options

tests/unit/test-022-utils.py

Loading...
View Options

tests/unit/test-030-recipientpolicy.py

Loading...