Extract the getServerModifications method
ClosedPublic
Actions

Authored by mollekopf on Sep 20 2024, 8:46 AM.

Project Tags

None

Referenced Files

	F117917016: D4953.1775412665.diff
	Sat, Apr 4, 6:11 PM

	F117893410: D4953.1775367431.diff
	Sat, Apr 4, 5:37 AM

	F117764799: D4953.1775228612.diff
	Thu, Apr 2, 3:03 PM

Subscribers

machniak

Details

Reviewers

machniak

Group Reviewers

Syncroton Developers

Commits

rSd977649a31ed: Extract the getServerModifications method

Diff Detail

Repository

rS syncroton

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Sep 20 2024, 8:46 AM

mollekopf created this revision.

Harbormaster completed remote builds in B50388: Diff 14181.Sep 20 2024, 8:48 AM

mollekopf added a reviewer: Syncroton Developers.Sep 20 2024, 8:48 AM

This is just a refactoring and shouldn't change the behaviour.

machniak requested changes to this revision.Sep 20 2024, 11:38 AM

machniak subscribed.

machniak added inline comments.

lib/ext/Syncroton/Command/Sync.php
512	Undefined variable $clientModifications.

This revision now requires changes to proceed.Sep 20 2024, 11:38 AM

Fixed the undefined $clientModifications

Harbormaster completed remote builds in B50415: Diff 14208.Sep 22 2024, 8:34 AM

machniak accepted this revision.Sep 22 2024, 3:00 PM

This revision is now accepted and ready to land.Sep 22 2024, 3:00 PM

Closed by commit rSd977649a31ed: Extract the getServerModifications method. · Explain WhyOct 9 2024, 7:54 AM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rSd977649a31ed: Extract the getServerModifications method.

Revision Contents
Changeset List

Path

Size

lib/

ext/

Syncroton/

Command/

Sync.php

lines

Diff 14274

View Options

lib/ext/Syncroton/Command/Sync.php

Extract the getServerModifications methodClosedPublicActions