Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rKf816b72a099a: SMTP content filter

Summary

The engine

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Branch

dev/smtp-content-filter

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 50655
Build 18444: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Oct 2 2024, 12:13 PM

machniak created this revision.

Harbormaster completed remote builds in B50655: Diff 14238.Oct 2 2024, 12:13 PM

Set back SWOOLE_PACKAGE_MAX_LENGTH to 10MB

Harbormaster completed remote builds in B50658: Diff 14241.Oct 2 2024, 12:31 PM

Support multipart/form-data file uploads, they don't need so much memory

Harbormaster completed remote builds in B50679: Diff 14253.Oct 4 2024, 2:16 PM

Don't require specific file name

Harbormaster completed remote builds in B50682: Diff 14256.Oct 4 2024, 2:28 PM

Invitations policy
Split itip handling into per-method classes

Harbormaster completed remote builds in B50766: Diff 14301.Oct 18 2024, 2:55 PM

Itip notifications

Harbormaster completed remote builds in B50847: Diff 14337.Fri, Oct 25, 3:21 PM

Besides the one complaint I think this can go in. I didn't investigate the rules in detail, but it's standalone enough that pushing it seems fairly risk free.

src/app/Policy/Mailfilter/RequestHandler.php
67	Still really don't like the string assembly to class approach. Just use the Class (App\Policy\Mailfilter\Modules\ItipModule::class) to fill the array. This for instance immediately make it evident if there is a typo, or a class is deleted but still used here etc.

This revision is now accepted and ready to land.Thu, Oct 31, 10:38 AM

This revision was landed with ongoing or failed builds.Thu, Oct 31, 2:27 PM

Closed by commit rKf816b72a099a: SMTP content filter (authored by machniak). · Explain Why

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rKf816b72a099a: SMTP content filter.

SMTP content filter
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 14238

src/app/Http/Controllers/API/V4/PolicyController.php

src/app/Policy/Mailfilter/MailParser.php

src/app/Policy/Mailfilter/Modules/ItipModule.php

src/app/Policy/Mailfilter/RequestHandler.php

src/app/Policy/Mailfilter/Result.php

src/composer.json

src/config/octane.php

src/routes/api.php

src/tests/Feature/Controller/PolicyTest.php

src/tests/Feature/Policy/Mailfilter/Modules/ItipModuleTest.php

src/tests/Unit/Policy/Mailfilter/MailParserTest.php

src/tests/data/mailfilter/itip1.eml

SMTP content filterClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14238

src/app/Http/Controllers/API/V4/PolicyController.php

src/app/Policy/Mailfilter/MailParser.php

src/app/Policy/Mailfilter/Modules/ItipModule.php

src/app/Policy/Mailfilter/RequestHandler.php

src/app/Policy/Mailfilter/Result.php

src/composer.json

src/config/octane.php

src/routes/api.php

src/tests/Feature/Controller/PolicyTest.php

src/tests/Feature/Policy/Mailfilter/Modules/ItipModuleTest.php

src/tests/Unit/Policy/Mailfilter/MailParserTest.php

src/tests/data/mailfilter/itip1.eml

SMTP content filter
ClosedPublic
Actions

Revision Contents
Changeset List