Project Tags

None

Referenced Files

	F117872674: D4974.1775330917.diff
	Fri, Apr 3, 7:28 PM

	F117869662: D4974.1775326409.diff
	Fri, Apr 3, 6:13 PM

	F117868006: D4974.1775323915.diff
	Fri, Apr 3, 5:31 PM

	F117863162: D4974.1775320341.diff
	Fri, Apr 3, 4:32 PM

Subscribers

mollekopf

Restricted Project

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rKf816b72a099a: SMTP content filter

Summary

The engine

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Branch

dev/smtp-content-filter

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/app/User.php:70	phpstan	Property App\User::$allowed_states is never read, only written.
Warning	src/resources/views/emails/html/itip_notification.blade.php:1	PHPCS.W.Internal.NoCodeFound	Internal.NoCodeFound
Warning	src/resources/views/emails/plain/itip_notification.blade.php:1	PHPCS.W.Internal.NoCodeFound	Internal.NoCodeFound

Unit

No Test Coverage

Build Status

Buildable 50847
Build 18498: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Oct 2 2024, 10:13 AM

machniak created this revision.

Harbormaster completed remote builds in B50655: Diff 14238.Oct 2 2024, 10:13 AM

Set back SWOOLE_PACKAGE_MAX_LENGTH to 10MB

Harbormaster completed remote builds in B50658: Diff 14241.Oct 2 2024, 10:31 AM

Support multipart/form-data file uploads, they don't need so much memory

Harbormaster completed remote builds in B50679: Diff 14253.Oct 4 2024, 12:16 PM

Don't require specific file name

Harbormaster completed remote builds in B50682: Diff 14256.Oct 4 2024, 12:28 PM

Invitations policy
Split itip handling into per-method classes

Harbormaster completed remote builds in B50766: Diff 14301.Oct 18 2024, 12:55 PM

Itip notifications

Harbormaster completed remote builds in B50847: Diff 14337.Oct 25 2024, 1:21 PM

Besides the one complaint I think this can go in. I didn't investigate the rules in detail, but it's standalone enough that pushing it seems fairly risk free.

src/app/Policy/Mailfilter/RequestHandler.php
66	Still really don't like the string assembly to class approach. Just use the Class (App\Policy\Mailfilter\Modules\ItipModule::class) to fill the array. This for instance immediately make it evident if there is a typo, or a class is deleted but still used here etc.

This revision is now accepted and ready to land.Oct 31 2024, 9:38 AM

This revision was landed with ongoing or failed builds.Oct 31 2024, 1:27 PM

Closed by commit rKf816b72a099a: SMTP content filter. · Explain Why

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rKf816b72a099a: SMTP content filter.

SMTP content filterClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14337

src/.gitignore

src/app/Backends/DAV.php

src/app/Backends/DAV/Folder.php

src/app/Backends/DAV/Opaque.php

src/app/Backends/DAV/Search.php

src/app/Backends/DAV/SearchCompFilter.php

src/app/Backends/DAV/SearchFilter.php

src/app/Backends/DAV/SearchPropFilter.php

src/app/Backends/DAV/Vevent.php

src/app/Backends/DAV/Vtodo.php

src/app/Console/Commands/DB/ExpungeCommand.php

src/app/Console/Kernel.php

src/app/Http/Controllers/API/V4/PolicyController.php

src/app/Policy/Mailfilter/MailParser.php

src/app/Policy/Mailfilter/Modules/ItipModule.php

src/app/Policy/Mailfilter/Modules/ItipModule/CancelHandler.php

src/app/Policy/Mailfilter/Modules/ItipModule/ReplyHandler.php

src/app/Policy/Mailfilter/Modules/ItipModule/RequestHandler.php

src/app/Policy/Mailfilter/Notifications/ItipNotification.php

src/app/Policy/Mailfilter/Notifications/ItipNotificationMail.php

src/app/Policy/Mailfilter/Notifications/ItipNotificationParams.php

src/app/Policy/Mailfilter/RequestHandler.php

src/app/Policy/Mailfilter/Result.php

src/app/User.php

src/composer.json

src/config/octane.php

src/phpstan.neon

src/resources/lang/en/mail.php

src/resources/views/emails/html/itip_notification.blade.php

src/resources/views/emails/plain/itip_notification.blade.php

src/routes/api.php

src/tests/BackendsTrait.php

src/tests/Feature/Console/DB/ExpungeTest.php

src/tests/Feature/Controller/PolicyTest.php

src/tests/Feature/Policy/Mailfilter/Modules/ItipModule/CancelHandlerTest.php

src/tests/Feature/Policy/Mailfilter/Modules/ItipModule/ReplyHandlerTest.php

src/tests/Feature/Policy/Mailfilter/Modules/ItipModule/RequestHandlerTest.php

src/tests/Unit/Backends/DAV/VeventTest.php

src/tests/Unit/Policy/Mailfilter/MailParserTest.php

src/tests/Unit/Policy/Mailfilter/Notifications/ItipNotificationMailTest.php

src/tests/data/mailfilter/event1.ics

src/tests/data/mailfilter/event2.ics

src/tests/data/mailfilter/event3.ics

src/tests/data/mailfilter/event4.ics

src/tests/data/mailfilter/event5.ics

src/tests/data/mailfilter/itip1_cancel.eml

src/tests/data/mailfilter/itip1_reply.eml

src/tests/data/mailfilter/itip1_request.eml

src/tests/data/mailfilter/itip2_cancel.eml

src/tests/data/mailfilter/itip2_reply.eml

src/tests/data/mailfilter/itip2_request.eml

src/tests/data/mailfilter/itip3_request_rrule_update.eml

SMTP content filter
ClosedPublic
Actions

Revision Contents
Changeset List