Page MenuHomePhorge
Differential D4953

Extract the getServerModifications method
AcceptedPublic
Actions

Authored by mollekopf on Fri, Sep 20, 10:46 AM.
Tags
None
Referenced Files
F15626817: D4953.id14209.diff
Sun, Sep 29, 1:54 AM
Unknown Object (File)
Sat, Sep 28, 6:55 PM
Unknown Object (File)
Sat, Sep 28, 2:14 AM
Unknown Object (File)
Fri, Sep 27, 2:18 PM
Unknown Object (File)
Fri, Sep 27, 1:14 PM
Unknown Object (File)
Thu, Sep 26, 5:31 PM
Unknown Object (File)
Mon, Sep 23, 5:42 PM
Unknown Object (File)
Mon, Sep 23, 5:39 PM
View All 18 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Syncroton Developers

Diff Detail

Repository
rS syncroton
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 50415
Build 18423: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Fri, Sep 20, 10:46 AM
mollekopf created this revision.
Harbormaster completed remote builds in B50388: Diff 14181.Fri, Sep 20, 10:48 AM
mollekopf added a reviewer: Syncroton Developers.Fri, Sep 20, 10:48 AM
mollekopf added a comment.Fri, Sep 20, 11:05 AM

This is just a refactoring and shouldn't change the behaviour.

machniak requested changes to this revision.Fri, Sep 20, 1:38 PM
machniak subscribed.
machniak added inline comments.
lib/ext/Syncroton/Command/Sync.php
512

Undefined variable $clientModifications.

This revision now requires changes to proceed.Fri, Sep 20, 1:38 PM
mollekopf updated this revision to Diff 14208.Sun, Sep 22, 10:34 AM

Fixed the undefined $clientModifications

Harbormaster completed remote builds in B50415: Diff 14208.Sun, Sep 22, 10:34 AM
machniak accepted this revision.Sun, Sep 22, 5:00 PM
This revision is now accepted and ready to land.Sun, Sep 22, 5:00 PM

Revision Contents
Changeset List

PathSize
lib/
ext/
Syncroton/
Command/
177 lines

Diff 14208

View Options

lib/ext/Syncroton/Command/Sync.php

Loading...