Log failure reason
ClosedPublic
Actions

Authored by mollekopf on Sep 2 2024, 2:56 PM.

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rK0bb0414fd53e: Log failure reason

Repository

rK kolab

Branch

master

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 48903
Build 18360: arc lint + arc unit

mollekopf requested review of this revision.Sep 2 2024, 2:56 PM

mollekopf created this revision.

So I don't have to go modify production code to figure out that geolocation somehow blocks the login attempt.

mollekopf added a reviewer: Restricted Project.Sep 2 2024, 2:57 PM

machniak added inline comments.

src/app/Http/Controllers/API/AuthController.php
86	This message should have some context. Maybe add "Auth: " prefix to it or something. Also, I'm not sure it makes sense to log anything at this point. Do we want to log user input on every login?

src/app/Http/Controllers/API/AuthController.php
86	Maybe it doesn't need to be a warning. When troubleshooting it's very useful to get an indication what is going wrong, and a generic 401 is rather useless, so in general I think yes, we should be logging something. It may be too noisy by default though.