Page MenuHomePhorge

Log failure reason
ClosedPublic

Authored by mollekopf on Sep 2 2024, 2:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 5:09 AM
Unknown Object (File)
Sat, Sep 28, 12:25 PM
Unknown Object (File)
Sat, Sep 21, 7:19 PM
Unknown Object (File)
Sat, Sep 21, 5:30 PM
Unknown Object (File)
Sat, Sep 21, 4:05 PM
Unknown Object (File)
Sat, Sep 21, 8:00 AM
Unknown Object (File)
Sat, Sep 21, 6:55 AM
Unknown Object (File)
Thu, Sep 19, 10:40 AM
Subscribers

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK0bb0414fd53e: Log failure reason

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.

So I don't have to go modify production code to figure out that geolocation somehow blocks the login attempt.

mollekopf added a reviewer: Restricted Project.Sep 2 2024, 2:57 PM
machniak added inline comments.
src/app/Http/Controllers/API/AuthController.php
86

This message should have some context. Maybe add "Auth: " prefix to it or something.

Also, I'm not sure it makes sense to log anything at this point. Do we want to log user input on every login?

src/app/Http/Controllers/API/AuthController.php
86

Maybe it doesn't need to be a warning. When troubleshooting it's very useful to get an indication what is going wrong, and a generic 401 is rather useless, so in general I think yes, we should be logging something. It may be too noisy by default though.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2024, 2:18 PM
Closed by commit rK0bb0414fd53e: Log failure reason (authored by mollekopf). · Explain Why
This revision was automatically updated to reflect the committed changes.