Fixes internal cache use that prevents redundant DB queries
Details
Details
- Reviewers
mollekopf - Group Reviewers
Syncroton Developers - Commits
- rSbb69706d7895: Fix relations state cache
Diff Detail
Diff Detail
- Repository
- rS syncroton
- Branch
- dev/perf-fix-relations
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 48486 Build 18288: arc lint + arc unit
Event Timeline
| lib/kolab_sync_storage.php | ||
|---|---|---|
| 1984 | But this is supposed to remove all cache entries except the current one which identified by $synctime, so if $synctime and $row['synctime'] are different we would remove the current cache entry and instead leave the previous one, no? It may not matter because we just always get the latest. | |
| lib/kolab_sync_storage.php | ||
|---|---|---|
| 1976 | This copies the latest database entry into the current $synctime cache, so that seems to indeed make more sense than reusing the synctime of the previous database entry. | |
| lib/kolab_sync_storage.php | ||
|---|---|---|
| 1984 | nevermind, "current" is not the new entry, but the one that latest that exists. | |