Page MenuHomePhorge

Fix relations state cache
ClosedPublic

Authored by machniak on Aug 14 2024, 11:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 24, 2:29 AM
Unknown Object (File)
Fri, Aug 23, 5:31 PM
Unknown Object (File)
Fri, Aug 23, 10:43 AM
Unknown Object (File)
Fri, Aug 23, 2:40 AM
Unknown Object (File)
Fri, Aug 23, 12:18 AM
Unknown Object (File)
Wed, Aug 21, 9:50 PM
Unknown Object (File)
Wed, Aug 21, 8:33 PM
Unknown Object (File)
Wed, Aug 21, 7:43 PM

Details

Summary

Fixes internal cache use that prevents redundant DB queries

Diff Detail

Repository
rS syncroton
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
mollekopf added inline comments.
lib/kolab_sync_storage.php
1984

But this is supposed to remove all cache entries except the current one which identified by $synctime, so if $synctime and $row['synctime'] are different we would remove the current cache entry and instead leave the previous one, no? It may not matter because we just always get the latest.

lib/kolab_sync_storage.php
1976–1977

This copies the latest database entry into the current $synctime cache, so that seems to indeed make more sense than reusing the synctime of the previous database entry.

mollekopf added inline comments.
lib/kolab_sync_storage.php
1984

nevermind, "current" is not the new entry, but the one that latest that exists.

This revision is now accepted and ready to land.Aug 14 2024, 12:54 PM
This revision was automatically updated to reflect the committed changes.